Summary

Port proxy type chooser to an AdwComboRow

Review Request #1712 — Created Sept. 3, 2022 and submitted Sept. 6, 2022, 4:55 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This changes the Proxy type prefs setting to an AdwComboRow.

I also don't love that the pref values and translated description strings get split up, but I think this is something that would be fixed with setting schemas?

Testing Done

Opened Prefs and changed Proxy type setting.

Commits

Summary	ID
Port proxy type chooser to an AdwComboRow	0cebcadedd4c42273dd2258b1d087ef3f27887cb

Everything looks fine here. I'm not sure what else you had in mind for the PoC.. The translation split up is kind of weird, but not a huge deal. Let me know how you'd like to proceed.

QuLogic Sept. 6, 2022, 4:21 a.m.

I added a helper now, as we can re-use a bit with the Away prefs.

Change Summary:

Add a helper for binding the AdwComboRow.

Commits:

	Summary	ID
	Port proxy type chooser to an AdwComboRow	f57c626e7da6c6e85d3cf9e90861f39d2990c9bc
	Port proxy type chooser to an AdwComboRow	4ffef188f238f8b5d9366c915ef935ea6b00eaac

Diff:

Revision 2 (+172 -104)

Show changes

	pidgin/prefs/pidginprefs.c
	pidgin/prefs/pidginprefsinternal.h
	pidgin/prefs/pidginproxyprefs.c
	pidgin/resources/Prefs/proxy.ui

Change Summary:: Update description
Summary:: PoC: Port proxy type chooser to an AdwComboRow
Port proxy type chooser to an AdwComboRow
Description:: ~
This is a proof of concept of changing the Proxy type prefs setting to an AdwComboRow. There's no helper binding function yet, so it's just sort of inlined. I haven't yet figured out if the other uses would be similar enough to justify a helper.
~
This changes the Proxy type prefs setting to an AdwComboRow.

I also don't love that the pref values and translated description strings get split up, but I think this is something that would be fixed with setting schemas?

Change Summary:

Avoid an extra strdup and minor style fixing.

Commits:

	Summary	ID
	Port proxy type chooser to an AdwComboRow	4ffef188f238f8b5d9366c915ef935ea6b00eaac
	Port proxy type chooser to an AdwComboRow	41279fcd82516061c4d94625cb619a35ead4d7ba

Diff:

Revision 3 (+170 -104)

Show changes

	pidgin/prefs/pidginprefs.c
	pidgin/prefs/pidginprefsinternal.h
	pidgin/prefs/pidginproxyprefs.c
	pidgin/resources/Prefs/proxy.ui

Change Summary:

Inline parts of the .ui file.

Commits:

	Summary	ID
	Port proxy type chooser to an AdwComboRow	41279fcd82516061c4d94625cb619a35ead4d7ba
	Port proxy type chooser to an AdwComboRow	0cebcadedd4c42273dd2258b1d087ef3f27887cb

Diff:

Revision 4 (+186 -116)

Show changes

	pidgin/prefs/pidginprefs.c
	pidgin/prefs/pidginprefsinternal.h
	pidgin/prefs/pidginproxyprefs.c
	pidgin/resources/Prefs/proxy.ui

Ship it!

```
Ship It!
```
```
Great work, thanks!!
```

Status:: Completed

~		This is a proof of concept of changing the Proxy type prefs setting to an `AdwComboRow`. There's no helper binding function yet, so it's just sort of inlined. I haven't yet figured out if the other uses would be similar enough to justify a helper.
	~	This changes the Proxy type prefs setting to an `AdwComboRow`.

		I also don't love that the pref values and translated description strings get split up, but I think this is something that would be fixed with setting schemas?