Port proxy type chooser to an AdwComboRow

Review Request #1712 — Created Sept. 3, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

This changes the Proxy type prefs setting to an AdwComboRow.

I also don't love that the pref values and translated description strings get split up, but I think this is something that would be fixed with setting schemas?

Opened Prefs and changed Proxy type setting.

Summary ID
Port proxy type chooser to an AdwComboRow
0cebcadedd4c42273dd2258b1d087ef3f27887cb
grim
  1. 
      
  2. Everything looks fine here. I'm not sure what else you had in mind for the PoC.. The translation split up is kind of weird, but not a huge deal. Let me know how you'd like to proceed.

    1. I added a helper now, as we can re-use a bit with the Away prefs.

  3. 
      
QuLogic
QuLogic
QuLogic
QuLogic
grim
  1. Ship It!
  2. Great work, thanks!!

  3. 
      
grim
Review request changed
Status:
Completed