Port proxy type chooser to an AdwComboRow
Review Request #1712 — Created Sept. 3, 2022 and submitted
This changes the Proxy type prefs setting to an
AdwComboRow
.I also don't love that the pref values and translated description strings get split up, but I think this is something that would be fixed with setting schemas?
Opened Prefs and changed
Proxy type
setting.
Summary | ID |
---|---|
0cebcadedd4c42273dd2258b1d087ef3f27887cb |
Change Summary:
Add a helper for binding the
AdwComboRow
.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+172 -104) |
Change Summary:
Update description
Summary: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Change Summary:
Avoid an extra strdup and minor style fixing.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+170 -104) |
Change Summary:
Inline parts of the .ui file.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+186 -116) |