Summary

Fix up the roomlist to work in GTK4

Review Request #1648 — Created Aug. 25, 2022 and submitted Aug. 26, 2022, 5:13 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

Groups

People

Description

Fix up the roomlist to work in GTK4

Testing Done

Opened the room list and verified it functioned as intended.

Commits

Summary	ID
Fix up the roomlist to work in GTK4	a0974a1785a713dd856a009463eb67653d44a988

Issues

Description	From	Last Updated
Maybe also GTK_RESPONSE_DELETE_EVENT as in the other dialog?	QuLogic	Aug. 26, 2022, 4:33 a.m.
Swap space and *	QuLogic	Aug. 26, 2022, 4:33 a.m.
May want to cast to gint on x/y.	QuLogic	Aug. 26, 2022, 4:34 a.m.
Probably don't need these on the action widgets.	QuLogic	Aug. 26, 2022, 4:34 a.m.
Ditto.	QuLogic	Aug. 26, 2022, 4:34 a.m.
Ditto.	QuLogic	Aug. 26, 2022, 4:34 a.m.
Ditto.	QuLogic	Aug. 26, 2022, 4:34 a.m.
Ditto.	QuLogic	Aug. 26, 2022, 4:34 a.m.

pidgin/gtkroomlist.c (Diff revision 1)

Show all issues

Maybe also GTK_RESPONSE_DELETE_EVENT as in the other dialog?

pidgin/gtkroomlist.c (Diff revision 1)
Show all issues
```
Swap space and *
```
pidgin/gtkroomlist.c (Diff revision 1)
Show all issues
```
May want to cast to gint on x/y.
```
pidgin/resources/Roomlist/roomlist.ui (Diff revision 1)
Show all issues
```
Probably don't need these on the action widgets.
```
pidgin/resources/Roomlist/roomlist.ui (Diff revision 1)
Show all issues
```
Ditto.
```
pidgin/resources/Roomlist/roomlist.ui (Diff revision 1)
Show all issues
```
Ditto.
```
pidgin/resources/Roomlist/roomlist.ui (Diff revision 1)
Show all issues
```
Ditto.
```
pidgin/resources/Roomlist/roomlist.ui (Diff revision 1)
Show all issues
```
Ditto.
```

address issues

	Summary	ID
	Fix up the roomlist to work in GTK4	15ad5addfd017c00c4de69076be49daee00b6088
	Fix up the roomlist to work in GTK4	a0974a1785a713dd856a009463eb67653d44a988

Revision 2 (+274 -330)

	pidgin/gtkroomlist.c
	pidgin/resources/Roomlist/roomlist.ui

Ship it!

Review Board 6.0.2