Summary

Add purple_notification_manager_remove_with_account.

Review Request #1612 — Created Aug. 21, 2022 and submitted Aug. 22, 2022, 8:21 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

1613

Reviewers

Groups

pidgin

People

Description

This is used when an account is disabled or removed to purge its notifications
from the manager.

Testing Done

Ran the unit tests and forced them to fail with bad values to verify they were correct.

Commits

Summary	ID
Add purple_notification_manager_remove_with_account. This is used when an account is disabled or removed to purge it's notifications from the manager.	a69bfd0a49f07e704755d76226cabe2e2a11a45c

Issues

Description	From	Last Updated
its	QuLogic	Aug. 22, 2022, 8:18 a.m.
I suppose this starts at 1 so that pattern can get 0 as a sentinel, but since it's a gint, …	QuLogic	Aug. 22, 2022, 8:18 a.m.

Description:

~		This is used when an account is disabled or removed to purge it's notifications
	~	This is used when an account is disabled or removed to purge its notifications
		from the manager.

libpurple/purplenotificationmanager.c (Diff revision 1)
Show all issues
```
its
```

libpurple/tests/test_notification_manager.c (Diff revision 1)

Show all issues

I suppose this starts at 1 so that pattern can get 0 as a sentinel, but since it's a gint, it could also get -1 as a sentinel?

grim Aug. 22, 2022, 8:04 a.m.

yeah, for some reason I was thinking it was a guint which is why I went with zero..

Change Summary:

address issues and add the header file change I somehow missed before?

Commits:

	Summary	ID
	Add purple_notification_manager_remove_with_account. This is used when an account is disabled or removed to purge it's notifications from the manager.	eb1c4a46c6a13166deac86162c6c09d024dc90d3
	Add purple_notification_manager_remove_with_account. This is used when an account is disabled or removed to purge it's notifications from the manager.	a69bfd0a49f07e704755d76226cabe2e2a11a45c

Diff:

Revision 2 (+352)

Show changes

	libpurple/purplenotificationmanager.h
	libpurple/purplenotificationmanager.c
	libpurple/tests/test_notification_manager.c

Ship it!

```
Ship It!
```

Review Board 6.0.2