Remove use of PidginCellRendererExpander

Review Request #1607 — Created Aug. 18, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

The point of this renderer is to draw an expander manually, thereby allowing
the tree view's expander to be hidden. This makes the contact appear at the
same indent level as the group. But if we're re-designing the whole widget,
there's probably not going to be a need for this manual work.

And it drops another file we'd need to port to GTK4.

Compiled and opened the buddy list; expanders were still there on groups. The contacts were just indented a bit more.

Summary ID
Remove use of PidginCellRendererExpander
The point of this renderer is to draw an expander manually, thereby allowing the tree view's expander to be hidden. This makes the contact appear at the same indent level as the group. But if we're re-designing the whole widget, there's probably not going to be a need for this manual work. And it drops another file we'd need to port to GTK4.
a576b2a1c9510a86ac5e61f8f819e305fc36da73
Description From Last Updated

Should we delete the column constants with this too?

grimgrim
QuLogic
grim
  1. 
      
  2. pidgin/gtkblist.c (Diff revision 2)
     
     

    Should we delete the column constants with this too?

  3. 
      
QuLogic
grim
  1. Ship It!
  2. Awesome work, thank you so very much!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...