Summary

Remove use of PidginCellRendererExpander

Review Request #1607 — Created Aug. 19, 2022 and submitted Aug. 19, 2022, 4:24 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The point of this renderer is to draw an expander manually, thereby allowing
the tree view's expander to be hidden. This makes the contact appear at the
same indent level as the group. But if we're re-designing the whole widget,
there's probably not going to be a need for this manual work.

And it drops another file we'd need to port to GTK4.

Testing Done

Compiled and opened the buddy list; expanders were still there on groups. The contacts were just indented a bit more.

Commits

Summary	ID
Remove use of PidginCellRendererExpander The point of this renderer is to draw an expander manually, thereby allowing the tree view's expander to be hidden. This makes the contact appear at the same indent level as the group. But if we're re-designing the whole widget, there's probably not going to be a need for this manual work. And it drops another file we'd need to port to GTK4.	a576b2a1c9510a86ac5e61f8f819e305fc36da73

Issues

Description	From	Last Updated
Should we delete the column constants with this too?	grim	Aug. 19, 2022, 4:22 a.m.

Change Summary:

Update API changelog

Commits:

	Summary	ID
	Remove use of PidginCellRendererExpander The point of this renderer is to draw an expander manually, thereby allowing the tree view's expander to be hidden. This makes the contact appear at the same indent level as the group. But if we're re-designing the whole widget, there's probably not going to be a need for this manual work. And it drops another file we'd need to port to GTK4.	ee5d81b336000017b3e19b819f9aad98eb8c14d2
	Remove use of PidginCellRendererExpander The point of this renderer is to draw an expander manually, thereby allowing the tree view's expander to be hidden. This makes the contact appear at the same indent level as the group. But if we're re-designing the whole widget, there's probably not going to be a need for this manual work. And it drops another file we'd need to port to GTK4.	06fd99b5ebe0b16739f5b1f57e339abaffc81330

Diff:

Revision 2 (+6 -530)

Show changes

	ChangeLog.API
	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidgincellrendererexpander.h
	pidgin/pidgincellrendererexpander.c
	po/POTFILES.in

pidgin/gtkblist.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Should we delete the column constants with this too?
```

Change Summary:

Remove expander columns also

Commits:

	Summary	ID
	Remove use of PidginCellRendererExpander The point of this renderer is to draw an expander manually, thereby allowing the tree view's expander to be hidden. This makes the contact appear at the same indent level as the group. But if we're re-designing the whole widget, there's probably not going to be a need for this manual work. And it drops another file we'd need to port to GTK4.	06fd99b5ebe0b16739f5b1f57e339abaffc81330
	Remove use of PidginCellRendererExpander The point of this renderer is to draw an expander manually, thereby allowing the tree view's expander to be hidden. This makes the contact appear at the same indent level as the group. But if we're re-designing the whole widget, there's probably not going to be a need for this manual work. And it drops another file we'd need to port to GTK4.	a576b2a1c9510a86ac5e61f8f819e305fc36da73

Diff:

Revision 3 (+6 -564)

Show changes

	ChangeLog.API
	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidgincellrendererexpander.h
	pidgin/pidgincellrendererexpander.c
	po/POTFILES.in

Ship it!

```
Ship It!
```
```
Awesome work, thank you so very much!
```

Status:: Completed

pidgin/gtkblist.c (Diff revision 2)