Inline pidgin_buddy_icon_chooser_new

Review Request #1601 — Created Aug. 16, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

Current GTK guidance says not to use gtk_file_chooser_set_current_folder.

Additionally, native file dialogs do not support previews on Windows, macOS, or when using portals. GTK4 does away with the API entirely.

Removing all this functionality means it's just a wrapper around creating the dialog, so just inline that and drop the function entirely.

Set an icon on a buddy, and also in a new account dialog.

Summary ID
Inline pidgin_buddy_icon_chooser_new
Current GTK guidance says not to use `gtk_file_chooser_set_current_folder`. Additionally, native file dialogs do not support previews on Windows, macOS, or when using portals. GTK4 does away with the API entirely. Removing all this functionality means it's just a wrapper around creating the dialog, so just inline that and drop the function entirely.
a115fc191afe66009820a2b9f49b659b98da4de0
grim
  1. Ship It!
  2. Great work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...