Summary

Port PidginAddBuddyDialog to GTK4

Review Request #1586 — Created Aug. 12, 2022 and submitted Aug. 15, 2022, 2:40 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

Groups

People

Description

Port PidginAddBuddyDialog to GTK4

Testing Done

Compiled

Commits

Summary	ID
Port PidginAddBuddyDialog to GTK4	adfaff51ecacde4c4b89f199e71ecb5f4f0bb0d0

Issues

Description	From	Last Updated
Not sure if this still exists.	QuLogic	Aug. 13, 2022, 10:42 p.m.
That seems wrong?	QuLogic	Aug. 13, 2022, 10:42 p.m.
hfill should be applied above.	QuLogic	Aug. 13, 2022, 10:43 p.m.
hfill should be applied above.	QuLogic	Aug. 13, 2022, 10:43 p.m.
hfill should be applied above.	QuLogic	Aug. 13, 2022, 10:43 p.m.
hfill should be applied above.	QuLogic	Aug. 13, 2022, 10:43 p.m.
Probably not right?	QuLogic	Aug. 13, 2022, 10:43 p.m.
hfill should be applied above.	QuLogic	Aug. 13, 2022, 10:43 p.m.
Isn't the action area normally horizontal?	QuLogic	Aug. 13, 2022, 10:44 p.m.

pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)

The issue has been resolved. Show all issues

That seems wrong?

ugh sorry, after a while of looking at this my eyes glaze over and this was clearly a case of that..

pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
hfill should be applied above.
```
pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
hfill should be applied above.
```
pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
hfill should be applied above.
```
pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
hfill should be applied above.
```
pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably not right?
```
pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
hfill should be applied above.
```
pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Isn't the action area normally horizontal?
```
1. grim Aug. 13, 2022, 10:01 p.m.
  hah whoops, good catch!

Change Summary:

address issues.

Commits:

	Summary	ID
	Port PidginAddBuddyDialog to GTK4	f7dc450580ed36af9e32227397fe2d53064908d4
	Port PidginAddBuddyDialog to GTK4	adfaff51ecacde4c4b89f199e71ecb5f4f0bb0d0

Diff:

Revision 2 (+150 -414)

	pidgin/pidginaddbuddydialog.c
	pidgin/resources/Dialogs/addbuddy.ui

Ship it!