Port PidginAddBuddyDialog to GTK4

Review Request #1586 — Created Aug. 12, 2022 and submitted

grim
pidgin/pidgin
gtk4
pidgin
Port PidginAddBuddyDialog to GTK4

Compiled

Summary
Port PidginAddBuddyDialog to GTK4
Description From Last Updated

Not sure if this still exists.

QuLogicQuLogic

That seems wrong?

QuLogicQuLogic

hfill should be applied above.

QuLogicQuLogic

hfill should be applied above.

QuLogicQuLogic

hfill should be applied above.

QuLogicQuLogic

hfill should be applied above.

QuLogicQuLogic

Probably not right?

QuLogicQuLogic

hfill should be applied above.

QuLogicQuLogic

Isn't the action area normally horizontal?

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     

    Not sure if this still exists.

    1. yeah this is gone.

  3. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     

    That seems wrong?

    1. ugh sorry, after a while of looking at this my eyes glaze over and this was clearly a case of that..

  4. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     
     

    hfill should be applied above.

  5. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     
     

    hfill should be applied above.

  6. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     
     

    hfill should be applied above.

  7. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     
     

    hfill should be applied above.

  8. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     

    Probably not right?

  9. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     
     

    hfill should be applied above.

  10. pidgin/resources/Dialogs/addbuddy.ui (Diff revision 1)
     
     

    Isn't the action area normally horizontal?

    1. hah whoops, good catch!

  11. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...