Summary

Start implementing the conversation window actions.

Review Request #1563 — Created Aug. 2, 2022 and submitted Aug. 9, 2022, 3:03 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Still not sure how we want to handle add/remove and block/unblock, but this is
small set of things to get us started.

Testing Done

Opened a conversation windown with multiple ims and a chat and verified that items sensitivity was set correctly depending on what was selected and made sure the actions work as well.

Side note, setting aliases on chats appears to have been broken outside of this change.

Commits

Summary	ID
Start implementing the conversation window actions. Still not sure how we want to handle add/remove and block/unblock, but this is small set of things to get us started.	356e41b1705cb9f6d9bb241ca44e025ca974d242

Issues

Description	From	Last Updated
De-align?	QuLogic	Aug. 9, 2022, 2:59 a.m.
Did you mean to implement chat Get Info as well? Otherwise, do we need the outer check? The inner check …	QuLogic	Aug. 9, 2022, 2:59 a.m.
Did you also mean to implement this for chat?	QuLogic	Aug. 9, 2022, 2:59 a.m.
Ditto.	QuLogic	Aug. 9, 2022, 2:59 a.m.
I don't think this is a thing; /*<private>	QuLogic	Aug. 9, 2022, 2:59 a.m.
If an IM is selected, enable the IM-specific ...	QuLogic	Aug. 9, 2022, 3:02 a.m.
If a chat is selected, enable ...	QuLogic	Aug. 9, 2022, 2:59 a.m.
Didn't fix 'enabled' yet.	QuLogic	Aug. 9, 2022, 3:02 a.m.

pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
De-align?
```

pidgin/pidginconversationwindow.c (Diff revision 1)

The issue has been dropped. Show all issues

Did you mean to implement chat Get Info as well?

Otherwise, do we need the outer check? The inner check is for a subclass of the outer check.

grim Aug. 9, 2022, 2:22 a.m.

There is no such thing as chat info right now, but I'm intending to implement it eventually. Previously, this uninituitively called get info on the user selected in the member list for the room when it was selected on a chat room.

pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Did you also mean to implement this for chat?
```
pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
I don't think this is a thing; /*<private>
```
pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
If an IM is selected, enable the IM-specific ...
```
pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
If a chat is selected, enable ...
```
pidgin/resources/gtk/menus.ui (Diff revision 1)
```
Heh, oops...
```

Commits:

	Summary	ID
	Start implementing the conversation window actions. Still not sure how we want to handle add/remove and block/unblock, but this is small set of things to get us started.	bcee309c8a3b89bc33691d4e7c513ba59caf6095
	Start implementing the conversation window actions. Still not sure how we want to handle add/remove and block/unblock, but this is small set of things to get us started.	ceecfa8fab853ac43871cd9e9d7204670e85007b

Diff:

Revision 2 (+558 -348)

Show changes

	pidgin/gtkconv.c
	pidgin/pidginconversationwindow.c
	pidgin/resources/gtk/menus.ui

Ship it!

```
Ship It!
```
pidgin/pidginconversationwindow.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Didn't fix 'enabled' yet.
```

Change Summary:

fix enabled comment

Commits:

	Summary	ID
	Start implementing the conversation window actions. Still not sure how we want to handle add/remove and block/unblock, but this is small set of things to get us started.	ceecfa8fab853ac43871cd9e9d7204670e85007b
	Start implementing the conversation window actions. Still not sure how we want to handle add/remove and block/unblock, but this is small set of things to get us started.	356e41b1705cb9f6d9bb241ca44e025ca974d242

Diff:

Revision 3 (+558 -348)

Show changes

	pidgin/gtkconv.c
	pidgin/pidginconversationwindow.c
	pidgin/resources/gtk/menus.ui

Status:: Completed