Start implementing the conversation window actions.

Review Request #1563 — Created Aug. 2, 2022 and submitted

grim
pidgin/pidgin
default
pidgin
Still not sure how we want to handle add/remove and block/unblock, but this is
small set of things to get us started.

Opened a conversation windown with multiple ims and a chat and verified that items sensitivity was set correctly depending on what was selected and made sure the actions work as well.

Side note, setting aliases on chats appears to have been broken outside of this change.

Summary
Start implementing the conversation window actions.
Description From Last Updated

De-align?

QuLogicQuLogic

Did you mean to implement chat Get Info as well? Otherwise, do we need the outer check? The inner check ...

QuLogicQuLogic

Did you also mean to implement this for chat?

QuLogicQuLogic

Ditto.

QuLogicQuLogic

I don't think this is a thing; /*<private>

QuLogicQuLogic

If an IM is selected, enable the IM-specific ...

QuLogicQuLogic

If a chat is selected, enable ...

QuLogicQuLogic

Didn't fix 'enabled' yet.

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     

    De-align?

  3. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     
     

    Did you mean to implement chat Get Info as well?

    Otherwise, do we need the outer check? The inner check is for a subclass of the outer check.

    1. There is no such thing as chat info right now, but I'm intending to implement it eventually. Previously, this uninituitively called get info on the user selected in the member list for the room when it was selected on a chat room.

  4. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     
     

    Did you also mean to implement this for chat?

  5. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     
  6. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     

    I don't think this is a thing; /*<private>

  7. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     

    If an IM is selected, enable the IM-specific ...

  8. pidgin/pidginconversationwindow.c (Diff revision 1)
     
     

    If a chat is selected, enable ...

  9. pidgin/resources/gtk/menus.ui (Diff revision 1)
     
     

    Heh, oops...

  10. 
      
grim
QuLogic
  1. Ship It!
  2. pidgin/pidginconversationwindow.c (Diff revision 2)
     
     

    Didn't fix 'enabled' yet.

  3. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...