Port the notifications API to GTK4

Review Request #1534 — Created July 20, 2022 and submitted

Information
grim
pidgin/pidgin
gtk4
Reviewers
pidgin 
Port the notifications API to GTK4
Compiled
Summary 
Port the notifications API to GTK4
Description From Last Updated

Seems accidentally included.

 QuLogicQuLogic

Should also be valign.

 QuLogicQuLogic
QuLogic
QuLogic 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Seems accidentally included.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      It's used on line 121 for an AdwStatusPage.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I meant this request is about notifications, but this file is for conversations, which I assume should go along with some .c file changes that aren't in here.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Sure, but the notifications are displayed in this conversation window. That said, yeah this is probably a drive by for the focus of this review request as it's that status page for conversations and not notifications. I can and will separate it out, but there are no other changes because we're this is a static status page.
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      Ah, okay.
      
 
      

      5. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      pidgin/resources/Notifications/list.ui
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should also be valign.
    
  
    
 
    

 
    
  



 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...