Summary

Port the notifications API to GTK4

Review Request #1534 — Created July 20, 2022 and submitted July 21, 2022, 8:47 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Port the notifications API to GTK4

Testing Done

Compiled

Commits

Summary	ID
Port the notifications API to GTK4	b283f0a5d0a9660bbe56646c6979ccd3f2be9fc7

Issues

Description	From	Last Updated
Seems accidentally included.	QuLogic	July 21, 2022, 7:44 p.m.
Should also be valign.	QuLogic	July 21, 2022, 3:17 p.m.

pidgin/resources/Conversations/window.ui (Diff revision 1)

The issue has been resolved. Show all issues

Seems accidentally included.

grim July 21, 2022, 12:29 a.m.

It's used on line 121 for an AdwStatusPage.

QuLogic July 21, 2022, 3:18 p.m.

I meant this request is about notifications, but this file is for conversations, which I assume should go along with some .c file changes that aren't in here.

grim July 21, 2022, 4:24 p.m.

Sure, but the notifications are displayed in this conversation window. That said, yeah this is probably a drive by for the focus of this review request as it's that status page for conversations and not notifications. I can and will separate it out, but there are no other changes because we're this is a static status page.

QuLogic July 21, 2022, 7:44 p.m.
```
Ah, okay.
```

pidgin/resources/Notifications/list.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Should also be valign.
```
1. grim July 21, 2022, 12:29 a.m.
  nice catch!

Change Summary:

re-add valign property

Commits:

	Summary	ID
	Port the notifications API to GTK4	44225c296e606a9a9f37890bebe2bef5e44df05f
	Port the notifications API to GTK4	5ea2d774e9b1a10ca7cc9f3c2ccef7bf381cf68a

Diff:

Revision 2 (+82 -118)

Show changes

	pidgin/pidginnotificationconnectionerror.h
	pidgin/pidginnotificationconnectionerror.c
	pidgin/resources/Conversations/window.ui
	pidgin/resources/Notifications/connectionerror.ui
	pidgin/resources/Notifications/list.ui

Change Summary:

removed the conversations placeholder page as it shouldn't have been in here in the first place.

Commits:

	Summary	ID
	Port the notifications API to GTK4	5ea2d774e9b1a10ca7cc9f3c2ccef7bf381cf68a
	Port the notifications API to GTK4	b283f0a5d0a9660bbe56646c6979ccd3f2be9fc7

Diff:

Revision 3 (+78 -114)

Show changes

	pidgin/pidginnotificationconnectionerror.h
	pidgin/pidginnotificationconnectionerror.c
	pidgin/resources/Notifications/connectionerror.ui
	pidgin/resources/Notifications/list.ui

Ship it!

```
Ship It!
```

Status:: Completed