Summary

Implement the UI for the new Notifications API.

Review Request #1512 — Created July 1, 2022 and submitted July 4, 2022, 11:29 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17634

Depends On

Reviewers

Groups

pidgin

People

Description

This currently only shows connection error notifications which have to be
removed manually since an account with a connection error can not currently
reconnect successfully.

Testing Done

I used a IRC account with an server name that was unresolvable as well as an XMPP account with a wrong password to cause a fatal connection errors.
I also used a IRC account connecting to a local instance of ZNC where I terminated ZNC to cause a server side connection failure.

Commits

Summary	ID
Implement the UI for the new Notifications API. This currently only shows connection error notifications which have to be removed manually since an account with a connection error can not currently reconnect successfully.	4833e6f798787762b2dbd8c8ae42a58a36652a0d

Files

Issues

Description	From	Last Updated
Error when building docs: WARNING: Unable to parse link Gets a [interface@Gio.ListModel] of all the [class@Notifications] in ^~~~~~~~~~~~~~~~~~~~~~~~~	ivanhoe	July 4, 2022, 10:56 p.m.
Should there maybe be a null check before using error?	ivanhoe	July 4, 2022, 10:56 p.m.

libpurple/purplenotificationmanager.h (Diff revision 1)

The issue has been resolved. Show all issues

Error when building docs:
WARNING: Unable to parse link
Gets a [interface@Gio.ListModel] of all the [class@Notifications] in
       ^~~~~~~~~~~~~~~~~~~~~~~~~

grim July 4, 2022, 5:25 p.m.

Not sure how I messed this up as I looked up the docs on the stream, but clearly it is wrong. it's supposed to be [iface@Gio.ListModel] and when I fixed that [class@nNotifications] errored out as well because the class name is Notification.

pidgin/pidginnotificationconnectionerror.c (Diff revision 1)

The issue has been resolved. Show all issues

Should there maybe be a null check before using error?

grim July 4, 2022, 5:25 p.m.

Shouldn't be necessary as this is only called by the property setter function (which is guaranted to be an instance), but it doesn't hurt anything so I'll add it anyways.

Change Summary:

address issues.

Commits:

	Summary	ID
	Implement the UI for the new Notifications API. This currently only shows connection error notifications which have to be removed manually since an account with a connection error can not currently reconnect successfully.	9b9d5f71bc1696fdb14119e3ac9744ab0f65d564
	Implement the UI for the new Notifications API. This currently only shows connection error notifications which have to be removed manually since an account with a connection error can not currently reconnect successfully.	4833e6f798787762b2dbd8c8ae42a58a36652a0d

Diff:

Revision 2 (+1570 -14)

Show changes

	libpurple/account.c
	libpurple/purplenotificationmanager.h
	libpurple/purplenotificationmanager.c
	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/pidginconversationwindow.c
	pidgin/pidginnotificationconnectionerror.h
	pidgin/pidginnotificationconnectionerror.c
	7 more

Ship it!

```
Ship It!
```

Status:: Completed