Implement the UI for the new Notifications API.

Review Request #1512 — Created July 1, 2022 and submitted

Information
grim
pidgin/pidgin
default
PIDGIN-17634
Reviewers
pidgin 
This currently only shows connection error notifications which have to be
removed manually since an account with a connection error can not currently
reconnect successfully.
I used a IRC account with an server name that was unresolvable as well as an XMPP account with a wrong password to cause a fatal connection errors.

I also used a IRC account connecting to a local instance of ZNC where I terminated ZNC to cause a server side connection failure.
Summary 
Implement the UI for the new Notifications API.

Description From Last Updated

Error when building docs: WARNING: Unable to parse link Gets a [interface@Gio.ListModel] of all the [class@Notifications] in ^~~~~~~~~~~~~~~~~~~~~~~~~

 ivanhoeivanhoe

Should there maybe be a null check before using error?

 ivanhoeivanhoe
ivanhoe
ivanhoe 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/purplenotificationmanager.h
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Error when building docs:
    

    WARNING: Unable to parse link
Gets a [interface@Gio.ListModel] of all the [class@Notifications] in
       ^~~~~~~~~~~~~~~~~~~~~~~~~

    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Not sure how I messed this up as I looked up the docs on the stream, but clearly it is wrong. it's supposed to be [iface@Gio.ListModel] and when I fixed that [class@nNotifications] errored out as well because the class name is Notification.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should there maybe be a null check before using error?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Shouldn't be necessary as this is only called by the property setter function (which is guaranted to be an instance), but it doesn't hurt anything so I'll add it anyways.
      
 
      

      2. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...