Fix purple_conversation_manager_find_chat_by_id.

 






 

 


  Review Request #1495
  —
  Created June 7, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  belgin, ivanhoe
 






 








 





  


 
 

  
purple_conversation_manager_find_chat_by_id was calling
purple_conversation_manager_find_internal with a name of NULL. However,
purple_conversation_manager_find_internal was always requring the conversation
name to matched what was passed in.
Therefore purple_conversation_manager_find_chat_by_id never actually worked.

 








  


 
 

  
Connected an IRC account and successfully sent a message.

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix purple_conversation_manager_find_chat_by_id.
     
purple_conversation_manager_find_chat_by_id was calling
purple_conversation_manager_find_internal with a name of NULL. However,
purple_conversation_manager_find_internal was always requring the conversation
name to matched what was passed in.
Therefore purple_conversation_manager_find_chat_by_id never actually worked.

    

   
  		
  5aa0160d757e1b013b4a7b3e184fc30ad7a058ca
  Gary Kramlich
 




    


    
    

   

  

 









 

  

   
    

     
      
      libpurple/purpleconversationmanager.c
     
    

   
  

 










     

    

   

  

  

   
   Loading...