Summary

Fix purple_conversation_manager_find_chat_by_id.

Review Request #1495 — Created June 6, 2022 and submitted June 9, 2022, 4:03 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

belgin, ivanhoe

Description

purple_conversation_manager_find_chat_by_id was calling
purple_conversation_manager_find_internal with a name of NULL. However,
purple_conversation_manager_find_internal was always requring the conversation
name to matched what was passed in.
Therefore purple_conversation_manager_find_chat_by_id never actually worked.

Testing Done

Connected an IRC account and successfully sent a message.

Commits

Summary	ID
Fix purple_conversation_manager_find_chat_by_id. purple_conversation_manager_find_chat_by_id was calling purple_conversation_manager_find_internal with a name of NULL. However, purple_conversation_manager_find_internal was always requring the conversation name to matched what was passed in. Therefore purple_conversation_manager_find_chat_by_id never actually worked.	5aa0160d757e1b013b4a7b3e184fc30ad7a058ca

Issues

Description	From	Last Updated
You might want to put if(func == NULL) return NULL; outside the while loop and remove the check from inside …	belgin	June 8, 2022, 2:47 p.m.
If account and conversation are both NULL, func is called with NULL as its first argument. I would check if …	belgin	June 8, 2022, 2:47 p.m.

libpurple/purpleconversationmanager.c (Diff revision 1)

Show all issues

You might want to put if(func == NULL) return NULL; outside the while loop and remove the check from inside it.

grim June 7, 2022, 2:26 a.m.

That's not quite the same thing, but I'll restore the old setup to make it easier to read.

libpurple/purpleconversationmanager.c (Diff revision 1)

Show all issues

If account and conversation are both NULL, func is called with NULL as its first argument.
I would check if account is non-NULL before the while loop and return early if it is.

grim June 7, 2022, 2:26 a.m.

conversation is verfied to not be null in purple_conversation_manager_register before it is inserted into the hash table.

Also callers of purple_conversation_manager_find_internal are already verifying that account is non-null.

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	Fix purple_conversation_manager_find_chat_by_id. purple_conversation_manager_find_chat_by_id was calling purple_conversation_manager_find_internal with a name of NULL. However, purple_conversation_manager_find_internal was always requring the conversation name to matched what was passed in. Therefore purple_conversation_manager_find_chat_by_id never actually worked.	ab9a5b0ba048cd6f356de9197dffce7b9d14b0c3
	Fix purple_conversation_manager_find_chat_by_id. purple_conversation_manager_find_chat_by_id was calling purple_conversation_manager_find_internal with a name of NULL. However, purple_conversation_manager_find_internal was always requring the conversation name to matched what was passed in. Therefore purple_conversation_manager_find_chat_by_id never actually worked.	5aa0160d757e1b013b4a7b3e184fc30ad7a058ca