Summary

Emit the irc-sending-text signal for all irc messages.

Review Request #1483 — Created May 27, 2022 and submitted May 31, 2022, 5:08 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-17626

Depends On

Reviewers

Groups

pidgin

People

Description

This was accidentally broken with the priority message sending stuff when the
rate limiter was added.

Testing Done

Connected to libera and everything seemed to be fine. Waited for the antispam timer and verified that both part and quit messages which use irc_priority_send worked via the irc-more plugin.

Commits

Summary	ID
Emit the irc-sending-text signal for all irc messages. This was accidentally broken with the priority message sending stuff when the rate limiter was added.	4179ee6c32e2349d088a5b0d21b9fa4d7abe4385

Issues

Description	From	Last Updated
Needs a strlen(tosend) instead of len here too	belgin	May 31, 2022, 4:55 a.m.
g_strndup, or otherwise, maybe can delete len argument?	QuLogic	May 31, 2022, 4:34 a.m.

Change Summary:

updated testing results

Testing Done:

~		Connected to libera and everything seemed to be fine.
	~	Connected to libera and everything seemed to be fine. Waited for the antispam timer and verified that both part and quit messages which use `irc_priority_send` worked via the `irc-more` plugin.
-
-		Currently waiting for their spam protection to let me use a part/quit message to verify completely.

libpurple/protocols/irc/irc.c (Diff revision 1)
Show all issues
```
Needs a strlen(tosend) instead of len here too
```
1. grim May 27, 2022, 10:55 p.m.
  nice catch!!

Change Summary:

add a missing strlen

Commits:

	Summary	ID
	Emit the irc-sending-text signal for all irc messages. This was accidentally broken with the priority message sending stuff when the rate limiter was added.	a826bb5c6a5e65226e4875b7d326ac7305e64f7f
	Emit the irc-sending-text signal for all irc messages. This was accidentally broken with the priority message sending stuff when the rate limiter was added.	9973172a864751e95116388f71804d574d8244fb

Diff:

Revision 2 (+40 -38)

Show changes

libpurple/protocols/irc/irc.c

libpurple/protocols/irc/irc.c (Diff revision 2)

Show all issues

g_strndup, or otherwise, maybe can delete len argument?

Change Summary:

use g_strndup

Commits:

	Summary	ID
	Emit the irc-sending-text signal for all irc messages. This was accidentally broken with the priority message sending stuff when the rate limiter was added.	9973172a864751e95116388f71804d574d8244fb
	Emit the irc-sending-text signal for all irc messages. This was accidentally broken with the priority message sending stuff when the rate limiter was added.	4179ee6c32e2349d088a5b0d21b9fa4d7abe4385

Diff:

Revision 3 (+40 -38)

Show changes

libpurple/protocols/irc/irc.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Emit the irc-sending-text signal for all irc messages.

Information

Reviewers

Change Summary:

Testing Done:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)