Fix unable to unblock XMPP buddy

Review Request #1479 — Created May 27, 2022 and submitted

Information

pidgin/pidgin
release-2.x.y

Reviewers

If the user blocked an XMPP buddy that was not in the buddy list,
Pidgin sent the XID with the resource to the server's block list.

If the user tried to unblock that buddy after adding them to the
buddy list, Pidgin sent the XID without the resource to the server
for unblocking.

This resulted in users unable to unblock their buddies.

This patch fixes this situation by sending just the normalized XID
(i.e. without the resource) to the server for blocking and
unblocking.

Tested on a Prosody XMPP server by adding a buddy and unblocking them.

Summary ID
Fix unable to unblock XMPP buddy
If the user blocked an XMPP buddy that was not in the buddy list, Pidgin sent the XID with the resource to the server's block list. If the user tried to unblock that buddy after adding them to the buddy list, Pidgin sent the XID without the resource to the server for unblocking. This resulted in users unable to unblock their buddies. This patch fixes this situation by sending just the normalized XID (i.e. without the resource) to the server for blocking and unblocking.
94f49057a77a2fe34ad0790d24b3025278565a45
grim
  1. Ship It!
  2. Awesome work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...