Summary

Port PidginProxyOptions to GTK4

Review Request #1421 — Created May 6, 2022 and submitted May 10, 2022, 3:21 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Port PidginProxyOptions to GTK4

Testing Done

Compiled.

Commits

Summary	ID
Port PidginProxyOptions to GTK4	0a21a4116051c0be0236dc300975a301412023b5

Issues

Description	From	Last Updated
I think you forgot to convert the .ui file?	QuLogic	May 9, 2022, 5:08 a.m.
Could this be put in the .ui file?	QuLogic	May 9, 2022, 5:07 a.m.
Shouldn't this say "along with this program"?	belgin	May 6, 2022, 9:29 p.m.
True as well, so should also be set?	QuLogic	May 10, 2022, 1:27 a.m.
Ditto.	QuLogic	May 10, 2022, 1:27 a.m.
Ditto.	QuLogic	May 10, 2022, 1:27 a.m.
Ditto.	QuLogic	May 10, 2022, 1:27 a.m.
Ditto.	QuLogic	May 10, 2022, 1:27 a.m.
You need the translators comment here as well since they may not appear together.	QuLogic	May 10, 2022, 1:27 a.m.

The issue has been resolved. Show all issues

I think you forgot to convert the .ui file?

pidgin/pidginproxyoptions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Could this be put in the .ui file?
```

Change Summary:

convert the ui file and move the easter egg to it.

Commits:

	Summary	ID
	Port PidginProxyOptions to GTK4	b0b1bc1cfe322e0f7c6883b5b51dc486fa4677d6
	Port PidginProxyOptions to GTK4	1498d08dd4ab99359b788c8f0c59b0060f8a2dd2

Diff:

Revision 2 (+116 -378)

Show changes

	pidgin/pidginproxyoptions.c
	pidgin/resources/proxyoptions.ui

pidgin/resources/proxyoptions.ui (Diff revision 2)
The issue has been dropped. Show all issues
```
Shouldn't this say "along with this program"?
```
1. grim May 6, 2022, 9:27 p.m.
  technically speaking this file ends up in libpidgin.so

pidgin/resources/proxyoptions.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
True as well, so should also be set?
```
pidgin/resources/proxyoptions.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/proxyoptions.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/proxyoptions.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/proxyoptions.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Ditto.
```

pidgin/resources/proxyoptions.ui (Diff revision 2)

The issue has been resolved. Show all issues

You need the translators comment here as well since they may not appear together.

grim May 9, 2022, 8:48 p.m.

I figured one would be okay, but you're right.

Change Summary:

address issues.

Commits:

	Summary	ID
	Port PidginProxyOptions to GTK4	1498d08dd4ab99359b788c8f0c59b0060f8a2dd2
	Port PidginProxyOptions to GTK4	0a21a4116051c0be0236dc300975a301412023b5

Diff:

Revision 3 (+136 -378)

Show changes

	pidgin/pidginproxyoptions.c
	pidgin/resources/proxyoptions.ui

Ship it!

```
Ship It!
```

Status:: Completed