Port PidginProxyOptions to GTK4

Review Request #1421 — Created May 6, 2022 and submitted

grim
pidgin/pidgin
gtk4
pidgin
Port PidginProxyOptions to GTK4

Compiled.

Summary
Port PidginProxyOptions to GTK4
Description From Last Updated

I think you forgot to convert the .ui file?

QuLogicQuLogic

Could this be put in the .ui file?

QuLogicQuLogic

Shouldn't this say "along with this program"?

belginbelgin

True as well, so should also be set?

QuLogicQuLogic

Ditto.

QuLogicQuLogic

Ditto.

QuLogicQuLogic

Ditto.

QuLogicQuLogic

Ditto.

QuLogicQuLogic

You need the translators comment here as well since they may not appear together.

QuLogicQuLogic
QuLogic
  1. 
      
  2. I think you forgot to convert the .ui file?

  3. pidgin/pidginproxyoptions.c (Diff revision 1)
     
     

    Could this be put in the .ui file?

  4. 
      
grim
belgin
  1. 
      
  2. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     

    Shouldn't this say "along with this program"?

    1. technically speaking this file ends up in libpidgin.so

  3. 
      
QuLogic
  1. 
      
  2. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     

    True as well, so should also be set?

  3. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     
  4. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     
  5. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     
  6. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     
  7. pidgin/resources/proxyoptions.ui (Diff revision 2)
     
     

    You need the translators comment here as well since they may not appear together.

    1. I figured one would be okay, but you're right.

  8. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...