Update the GTK request implementation for GTK4

Review Request #1414 — Created May 5, 2022 and submitted

grim
pidgin/pidgin
gtk4
pidgin

Update the GTK request implementation for GTK4

I had to #if 0 a fair amount of code as it needs rewriting and there's no point in doing that now when we can't test the rewrite.

Compiled

Summary
Update the GTK request implementation for GTK4
Description From Last Updated

Since there's an if (img after this, this icon size call should be later.

QuLogicQuLogic

Migrating guide says to use GtkEventControllerFocus, but maybe this is okay too?

QuLogicQuLogic

Doesn't this need to be added to something?

QuLogicQuLogic

Always true with save, so can just delete this.

QuLogicQuLogic

It seems like you missed this extra box which seems to take pages[i], add all the above hbox/vbox stuff, then ...

QuLogicQuLogic

Could just write that as: if(icon_name == NULL) { icon_name = "dialog-question"; } and then create once after.

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/gtkrequest.c (Diff revision 1)
     
     

    Since there's an if (img after this, this icon size call should be later.

    1. This whole function is a mess.. I have an update that maybe makes it's better, but like this is just bad code i'm trying to avoid fixing :-D

  3. pidgin/gtkrequest.c (Diff revision 1)
     
     
     

    Migrating guide says to use GtkEventControllerFocus, but maybe this is okay too?

  4. pidgin/gtkrequest.c (Diff revision 1)
     
     

    Doesn't this need to be added to something?

  5. pidgin/gtkrequest.c (Diff revision 1)
     
     
     
     
     

    Always true with save, so can just delete this.

  6. 
      
grim
QuLogic
  1. 
      
  2. pidgin/gtkrequest.c (Diff revision 2)
     
     
     
     
     

    It seems like you missed this extra box which seems to take pages[i], add all the above hbox/vbox stuff, then replace pages[i] as some inner child.

    1. well pages[i] potentially got over written and then repacked and stuff.. i dunno i need to review the original code a bit more.

    2. Yes, I think the point is to change the pages[i] into something with additional padding and rows/columns. The original is thrown away, but it's already added as a child somewhere. Possibly it could be a FlowBox or some other better widget these days.

  3. 
      
grim
QuLogic
  1. 
      
  2. pidgin/gtkrequest.c (Diff revision 3)
     
     
     
     
     
     
     
     

    Could just write that as:

    if(icon_name == NULL) {
        icon_name = "dialog-question";
    }
    

    and then create once after.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...