Summary

Update the GTK request implementation for GTK4

Review Request #1414 — Created May 6, 2022 and submitted May 24, 2022, 3:30 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Update the GTK request implementation for GTK4

I had to #if 0 a fair amount of code as it needs rewriting and there's no point in doing that now when we can't test the rewrite.

Testing Done

Compiled

Commits

Summary	ID
Update the GTK request implementation for GTK4	d6c178fddcd9973d1d872a318990ee4b6b56fe24

Issues

Description	From	Last Updated
Since there's an if (img after this, this icon size call should be later.	QuLogic	May 9, 2022, 10:07 a.m.
Migrating guide says to use GtkEventControllerFocus, but maybe this is okay too?	QuLogic	May 9, 2022, 10:07 a.m.
Doesn't this need to be added to something?	QuLogic	May 10, 2022, 2:44 a.m.
Always true with save, so can just delete this.	QuLogic	May 9, 2022, 10:07 a.m.
It seems like you missed this extra box which seems to take pages[i], add all the above hbox/vbox stuff, then …	QuLogic	May 24, 2022, 2:42 a.m.
Could just write that as: if(icon_name == NULL) { icon_name = "dialog-question"; } and then create once after.	QuLogic	May 24, 2022, 2:42 a.m.

pidgin/gtkrequest.c (Diff revision 1)

Show all issues

Since there's an if (img after this, this icon size call should be later.

grim May 6, 2022, 7:19 a.m.

This whole function is a mess.. I have an update that maybe makes it's better, but like this is just bad code i'm trying to avoid fixing :-D

pidgin/gtkrequest.c (Diff revision 1)

Show all issues

Migrating guide says to use GtkEventControllerFocus, but maybe this is okay too?

pidgin/gtkrequest.c (Diff revision 1)

Show all issues

Doesn't this need to be added to something?

pidgin/gtkrequest.c (Diff revision 1)

Show all issues

Always true with save, so can just delete this.

Change Summary:

address issues

Commits:

	Summary	ID
	Update the GTK request implementation for GTK4	a5dc3d4bb6a36c36742ad9cbfd496623ea2a284a
	Update the GTK request implementation for GTK4	cf99ec025fab36d453f05915c9715d94c3681a15

Diff:

Revision 2 (+532 -362)

Show changes

pidgin/gtkrequest.c

pidgin/gtkrequest.c (Diff revision 2)

Show all issues

It seems like you missed this extra box which seems to take pages[i], add all the above hbox/vbox stuff, then replace pages[i] as some inner child.

grim May 10, 2022, 8:49 a.m.

well pages[i] potentially got over written and then repacked and stuff.. i dunno i need to review the original code a bit more.

QuLogic May 10, 2022, 9:11 a.m.

Yes, I think the point is to change the pages[i] into something with additional padding and rows/columns. The original is thrown away, but it's already added as a child somewhere. Possibly it could be a FlowBox or some other better widget these days.

Change Summary:

remove the tab nonsense that was never completed by the looks of things.

Commits:

	Summary	ID
	Update the GTK request implementation for GTK4	cf99ec025fab36d453f05915c9715d94c3681a15
	Update the GTK request implementation for GTK4	3088a72bc334846109a45176a07f835557f60a61

Diff:

Revision 3 (+474 -602)

Show changes

pidgin/gtkrequest.c

pidgin/gtkrequest.c (Diff revision 3)

Show all issues

Could just write that as:
if(icon_name == NULL) {
    icon_name = "dialog-question";
}

and then create once after.

Commits:

	Summary	ID
	Update the GTK request implementation for GTK4	3088a72bc334846109a45176a07f835557f60a61
	Update the GTK request implementation for GTK4	d6c178fddcd9973d1d872a318990ee4b6b56fe24

Diff:

Revision 4 (+470 -604)

Show changes

pidgin/gtkrequest.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Update the GTK request implementation for GTK4

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Commits:

Diff:

Status: Closed (submitted)