Summary

Convert plugin actions to GMenu and GAction

Review Request #1408 — Created April 30, 2022 and submitted May 27, 2022, 7:53 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1412~~

Reviewers

Groups

pidgin

People

Description

Convert plugin actions to GMenu and GAction

Also ported the idle maker plugin to the new api.

Testing Done

Made sure all of the actions for the idle maker plugin worked.

Commits

Summary	ID
Convert plugin actions to GMenu and GAction	365f264e966a1de79ebf86e68a1e45238f222b16

Issues

Description	From	Last Updated
I wouldn't intersperse the g_menu_new up here, when the action group is done later.	QuLogic	May 27, 2022, 9:12 a.m.
Would calling the action directly not work?	QuLogic	May 27, 2022, 9:12 a.m.
I would say "action group"	QuLogic	May 27, 2022, 9:12 a.m.
And "menu model"	QuLogic	May 27, 2022, 9:12 a.m.
Flip order, just to match args.	QuLogic	May 27, 2022, 9:01 a.m.
Do we have to worry about removing these on plugin unload?	QuLogic	May 27, 2022, 9:15 a.m.
Given the if above, is this guaranteed non-NULL?	QuLogic	May 27, 2022, 9:13 a.m.
Do you have to check if either of these are NULL?	QuLogic	May 27, 2022, 9:20 a.m.
caller is interested	QuLogic	May 27, 2022, 9:13 a.m.
Isn't this guaranteed by pidgin_plugins_menu_add_item?	QuLogic	May 27, 2022, 9:13 a.m.

I'm not super happy with the plugin interface for this, but it does work.

grim May 1, 2022, 6:39 a.m.

Much happier with the interface now that the ui is controlling the namespace/prefix and the plugin doesn't need to care about it. We should probably do some normalization on this, but it works for now.

Change Summary:

have the plugins menu manage the namespace/prefix for the menu. This elimantes the need for the plugin to care about it and lets the ui just handle it.

Commits:

	Summary	ID
	Convert plugin actions to GMenu and GAction	de7c7d04898c502762bf7f63327b60fad0adebe6
	Convert plugin actions to GMenu and GAction	3c8cf009f78be6a354b4a7a90f8b7e72c21a4275

Diff:

Revision 2 (+746 -558)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/idle.c
	pidgin/pidginapplication.c
	pidgin/pidgincontactlist.c
	pidgin/pidginpluginsmenu.h
	pidgin/pidginpluginsmenu.c
	pidgin/glade/pidgin3.xml.in
	3 more

Depends On:: ~~1412 - Chain up to the parent class's implementation of the window_added default signal handler~~

Change Summary:

migrate to pidgin_application_add_action_group

Commits:

	Summary	ID
	Convert plugin actions to GMenu and GAction	3c8cf009f78be6a354b4a7a90f8b7e72c21a4275
	Convert plugin actions to GMenu and GAction	1a791d101d76f5e38b0d6ada61e2e9a246819358

Diff:

Revision 3 (+742 -558)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/idle.c
	pidgin/pidginapplication.c
	pidgin/pidgincontactlist.c
	pidgin/pidginpluginsmenu.h
	pidgin/pidginpluginsmenu.c
	pidgin/glade/pidgin3.xml.in
	3 more

Change Summary:

rebased

Commits:

	Summary	ID
	Convert plugin actions to GMenu and GAction	1a791d101d76f5e38b0d6ada61e2e9a246819358
	Convert plugin actions to GMenu and GAction	55f6afddf7e55999d1deb12b6427814296fbef8f

Diff:

Revision 4 (+742 -558)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/idle.c
	pidgin/pidginapplication.c
	pidgin/pidgincontactlist.c
	pidgin/pidginpluginsmenu.h
	pidgin/pidginpluginsmenu.c
	pidgin/glade/pidgin3.xml.in
	3 more

Change Summary:

rebased

Commits:

	Summary	ID
	Convert plugin actions to GMenu and GAction	55f6afddf7e55999d1deb12b6427814296fbef8f
	Convert plugin actions to GMenu and GAction	ccfaefc01779eb6b3513f878345d08d81249f90f

Diff:

Revision 5 (+742 -558)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/idle.c
	pidgin/pidginapplication.c
	pidgin/pidgincontactlist.c
	pidgin/pidginpluginsmenu.h
	pidgin/pidginpluginsmenu.c
	pidgin/glade/pidgin3.xml.in
	3 more

libpurple/plugins/idle.c (Diff revision 5)

The issue has been resolved. Show all issues

I wouldn't intersperse the g_menu_new up here, when the action group is done later.

libpurple/plugins/idle.c (Diff revision 5)
The issue has been resolved. Show all issues
```
Would calling the action directly not work?
```
libpurple/purpleplugininfo.c (Diff revision 5)
The issue has been resolved. Show all issues
```
I would say "action group"
```
libpurple/purpleplugininfo.c (Diff revision 5)
The issue has been resolved. Show all issues
```
And "menu model"
```

pidgin/pidginpluginsmenu.c (Diff revision 5)

The issue has been dropped. Show all issues

Flip order, just to match args.

grim May 27, 2022, 8:56 a.m.

Let's not, because if we do, then it goes "GPlugin, Pidgin, GPlugin" for the type names.

pidgin/pidginpluginsmenu.c (Diff revision 5)
The issue has been resolved. Show all issues
```
Do we have to worry about removing these on plugin unload?
```
pidgin/pidginpluginsmenu.c (Diff revision 5)
The issue has been resolved. Show all issues
```
Given the if above, is this guaranteed non-NULL?
```
pidgin/pidginpluginsmenu.c (Diff revision 5)
The issue has been resolved. Show all issues
```
caller is interested
```

pidgin/pidginpluginsmenu.c (Diff revision 5)

The issue has been resolved. Show all issues

Isn't this guaranteed by pidgin_plugins_menu_add_item?

grim May 27, 2022, 8:56 a.m.

Yes, but someone else could find the menu model and attempt to add stuff to it.

QuLogic May 27, 2022, 9:02 a.m.

But this is the menu model implementation, and its internals are not exposed, are they?

grim May 27, 2022, 9:08 a.m.

ah ha! I forgot that the model is read-only, so yes this should be fine.

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Convert plugin actions to GMenu and GAction	ccfaefc01779eb6b3513f878345d08d81249f90f
	Convert plugin actions to GMenu and GAction	7fca99f94245c71fcd5f9d4e6c66789c05827580

Diff:

Revision 6 (+762 -560)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/idle.c
	pidgin/pidginapplication.c
	pidgin/pidgincontactlist.c
	pidgin/pidginpluginsmenu.h
	pidgin/pidginpluginsmenu.c
	pidgin/glade/pidgin3.xml.in
	3 more

pidgin/pidginpluginsmenu.c (Diff revisions 5 - 6)
The issue has been resolved. Show all issues
```
Do you have to check if either of these are NULL?
```

Change Summary:

addressed issue.

Commits:

	Summary	ID
	Convert plugin actions to GMenu and GAction	7fca99f94245c71fcd5f9d4e6c66789c05827580
	Convert plugin actions to GMenu and GAction	365f264e966a1de79ebf86e68a1e45238f222b16

Diff:

Revision 7 (+770 -560)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/idle.c
	pidgin/pidginapplication.c
	pidgin/pidgincontactlist.c
	pidgin/pidginpluginsmenu.h
	pidgin/pidginpluginsmenu.c
	pidgin/glade/pidgin3.xml.in
	3 more

Ship it!

```
Ship It!
```

Status:: Completed