Convert plugin actions to GMenu and GAction
Review Request #1408 — Created April 30, 2022 and submitted
Convert plugin actions to GMenu and GAction
Also ported the idle maker plugin to the new api.
Made sure all of the actions for the idle maker plugin worked.
Summary | ID |
---|---|
365f264e966a1de79ebf86e68a1e45238f222b16 |
Description | From | Last Updated |
---|---|---|
I wouldn't intersperse the g_menu_new up here, when the action group is done later. |
QuLogic | |
Would calling the action directly not work? |
QuLogic | |
I would say "action group" |
QuLogic | |
And "menu model" |
QuLogic | |
Flip order, just to match args. |
QuLogic | |
Do we have to worry about removing these on plugin unload? |
QuLogic | |
Given the if above, is this guaranteed non-NULL? |
QuLogic | |
Do you have to check if either of these are NULL? |
QuLogic | |
caller is interested |
QuLogic | |
Isn't this guaranteed by pidgin_plugins_menu_add_item? |
QuLogic |
Change Summary:
have the plugins menu manage the namespace/prefix for the menu. This elimantes the need for the plugin to care about it and lets the ui just handle it.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+746 -558) |
Change Summary:
migrate to
pidgin_application_add_action_group
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+742 -558) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+742 -558) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+742 -558) |
-
-
libpurple/plugins/idle.c (Diff revision 5) I wouldn't intersperse the
g_menu_new
up here, when the action group is done later. -
-
-
-
-
pidgin/pidginpluginsmenu.c (Diff revision 5) Do we have to worry about removing these on plugin unload?
-
-
-
Change Summary:
rebased and addressed issues.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+762 -560) |