Add a field in IRC where users can explicitly set the SASL login name

Review Request #1388 — Created April 17, 2022 and submitted

belgin
pidgin/pidgin
release-2.x.y
PIDGIN-15451
pidgin
Add a field in IRC where users can explicitly set the SASL login name

Tested by setting the SASL login name and connecting with an alternative nickname. Also tested the fallback behavior in case SASL login name isn't set, but the user wants to login with SASL anyway.

Summary
Add a field in IRC where users can explicitly set the SASL login name
Description From Last Updated

This is wrapped kind of weird, might want to initialize on another line.

grimgrim

Curious why we're using the realname as a fallback here? I couldn't find any mention of it in the issue ...

grimgrim
grim
  1. 
      
  2. libpurple/protocols/irc/msgs.c (Diff revision 1)
     
     

    This is wrapped kind of weird, might want to initialize on another line.

  3. libpurple/protocols/irc/msgs.c (Diff revision 1)
     
     

    Curious why we're using the realname as a fallback here? I couldn't find any mention of it in the issue and I'm not coming up with a scenario where it might make sense. That said, I'm very possibly missing something.

    1. My thinking was that if only Real name is set (and SASL login name is not set), try logging in with Real name instead of the nickname to avoid the situation where the nickname is already used on the server and Pidgin refuses to login.
      I am not an expert on IRC so this behavior could be explicitly wrong in some RFC. If so, i will remove this fallback.

    2. Ah okay, makes sense!

  4. 
      
belgin
grim
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...