Summary

Add a field in IRC where users can explicitly set the SASL login name

Review Request #1388 — Created April 17, 2022 and submitted April 22, 2022, 1:21 a.m.

Information

Owner

belgin

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-15451

Depends On

Reviewers

Groups

pidgin

People

Description

Add a field in IRC where users can explicitly set the SASL login name

Testing Done

Tested by setting the SASL login name and connecting with an alternative nickname. Also tested the fallback behavior in case SASL login name isn't set, but the user wants to login with SASL anyway.

Commits

Summary	ID
Add a field in IRC where users can explicitly set the SASL login name Testing Done: Tested by setting the SASL login name and connecting with an alternative nickname. Also tested the fallback behavior in case SASL login name isn't set, but the user wants to login with SASL anyway. Bugs closed: PIDGIN-15451 Reviewed at https://reviews.imfreedom.org/r/1388/	66accd6546de1c89fc9e1a403a4ca2040bee6227

Issues

Description	From	Last Updated
This is wrapped kind of weird, might want to initialize on another line.	grim	April 19, 2022, 8:21 p.m.
Curious why we're using the realname as a fallback here? I couldn't find any mention of it in the issue …	grim	April 22, 2022, 1:17 a.m.

libpurple/protocols/irc/msgs.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This is wrapped kind of weird, might want to initialize on another line.
```

libpurple/protocols/irc/msgs.c (Diff revision 1)

The issue has been resolved. Show all issues

Curious why we're using the realname as a fallback here? I couldn't find any mention of it in the issue and I'm not coming up with a scenario where it might make sense. That said, I'm very possibly missing something.

belgin April 19, 2022, 8:34 a.m.

My thinking was that if only Real name is set (and SASL login name is not set), try logging in with Real name instead of the nickname to avoid the situation where the nickname is already used on the server and Pidgin refuses to login.
I am not an expert on IRC so this behavior could be explicitly wrong in some RFC. If so, i will remove this fallback.

grim April 22, 2022, 1:17 a.m.
```
Ah okay, makes sense!
```

Change Summary:

Fix the weird wrapping

Commits:

	Summary	ID
	Add a field in IRC where users can explicitly set the SASL login name	114341114fb5eafbbf7f19c0b30ad41937cad89e
	Add a field in IRC where users can explicitly set the SASL login name Testing Done: Tested by setting the SASL login name and connecting with an alternative nickname. Also tested the fallback behavior in case SASL login name isn't set, but the user wants to login with SASL anyway. Bugs closed: PIDGIN-15451 Reviewed at https://reviews.imfreedom.org/r/1388/	66accd6546de1c89fc9e1a403a4ca2040bee6227

Diff:

Revision 2 (+28 -2)

Show changes

	libpurple/protocols/irc/irc.c
	libpurple/protocols/irc/msgs.c

Ship it!

```
Ship It!
```

Status:: Completed