Summary

Fix IRC file transfers on Windows

Review Request #1382 — Created April 10, 2022 and submitted April 15, 2022, 4:13 p.m.

Information

Owner

belgin

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-17175

Depends On

Reviewers

Groups

pidgin

People

Description

This might also fix some other things, like getsockname
error #10014

Testing Done

Tested on Windows and Linux. Executed some file transfers over IRC and they worked.

Commits

Summary	ID
Fix IRC file transfers on Windows This might also fix some other things, like getsockname error #10014 Testing Done: Tested on Windows. Executed some file transfers over IRC and they worked. Bugs closed: PIDGIN-17175 Reviewed at https://reviews.imfreedom.org/r/1382/	62a28b30eb43a10b13b81be6627e02325fa9a1bd

Issues

Description	From	Last Updated
You mentioned testing on Windows? How about Linux or BSD? Don't need to test both, just need to make sure …	grim	April 11, 2022, 9:03 p.m.
trailing whitespace.	grim	April 11, 2022, 6:07 p.m.

Change Summary:: Add the bug that this is meant to fix.
Bugs:: PIDGIN-17175

The issue has been resolved. Show all issues

You mentioned testing on Windows? How about Linux or BSD? Don't need to test both, just need to make sure at least one of them still works after this.

belgin April 11, 2022, 9:03 p.m.

Tested on Linux. Still works as expected.

libpurple/network.c (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace.
```

Change Summary:

removed trailing whitespace

Commits:

	Summary	ID
	Fix IRC file transfers on Windows This might also fix some other things, like getsockname error #10014	ad6146a5e431ba706943a5c3ad99440436b18ce4
	Fix IRC file transfers on Windows This might also fix some other things, like getsockname error #10014 Testing Done: Tested on Windows. Executed some file transfers over IRC and they worked. Bugs closed: PIDGIN-17175 Reviewed at https://reviews.imfreedom.org/r/1382/	62a28b30eb43a10b13b81be6627e02325fa9a1bd

Diff:

Revision 2 (+20 -4)

Show changes

libpurple/network.c

Change Summary:: Updated "Testing Done" field to reflect that I have also tested on Linux.
Testing Done:: ~
Tested on Windows. Executed some file transfers over IRC and they worked.
~
Tested on Windows and Linux. Executed some file transfers over IRC and they worked.

Ship it!

```
Ship It!
```
```
Awesome work, thank you very much!!
```

Status:: Completed

~		Tested on Windows. Executed some file transfers over IRC and they worked.
	~	Tested on Windows and Linux. Executed some file transfers over IRC and they worked.

libpurple/network.c (Diff revision 1)