Summary

Create a PidginProxyOptions widget

Review Request #1377 — Created April 4, 2022 and submitted May 2, 2022, 11:45 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This replaces the old page in the account editor and uses a PurpleProxyInfo
object to for editing.

Testing Done

Verified it populated saved values on an existing account, as well as saved values on existing account.
Also verified that you can create a new account with proxy options and that they're saved.

Commits

Summary	ID
Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	f32f8d6e2f1fa44d1f2bcb0cddf1850081d28fcd

Issues

Description	From	Last Updated
double "the"	lifesfaded	April 5, 2022, 6:14 a.m.
double "the"	lifesfaded	April 5, 2022, 6:14 a.m.
humorous	lifesfaded	April 5, 2022, 6:14 a.m.
Missing space after B)	lifesfaded	April 5, 2022, 6:14 a.m.
This change in behavior is not necessarily a problem, but it looks like these are being prepended in a different …	jrchamp	April 7, 2022, 8:15 p.m.
This is transfer none, but the end of this function unrefs it?	QuLogic	May 2, 2022, 9:47 p.m.
How does this refresh correctly if options->show_global is set after?	QuLogic	May 2, 2022, 9:47 p.m.
Does this need to be done dynamically now that the store is a fixed list?	QuLogic	May 2, 2022, 10:22 p.m.
visible / visibility / the	QuLogic	May 2, 2022, 10:22 p.m.

pidgin/pidginproxyoptions.h (Diff revision 1)
The issue has been resolved. Show all issues
```
double "the"
```
pidgin/pidginproxyoptions.h (Diff revision 1)
The issue has been resolved. Show all issues
```
double "the"
```
pidgin/pidginproxyoptions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
humorous
```
pidgin/pidginproxyoptions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing space after B)
```

Change Summary:

fix some typos found in review

Commits:

	Summary	ID
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	fd4223deb8cb442b17e2fbf26e58b5d5f16ee864
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	fa25e49695df1284796c6c1142dec315bf156e50

Diff:

Revision 2 (+1764 -560)

Show changes

	pidgin/gtkaccount.c
	pidgin/meson.build
	pidgin/pidginproxyoptions.h
	pidgin/pidginproxyoptions.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/proxyoptions.ui
	po/POTFILES.in

pidgin/pidginproxyoptions.c (Diff revision 2)

The issue has been resolved. Show all issues

This change in behavior is not necessarily a problem, but it looks like these are being prepended in a different order. The original comment said /* Prepend these in reverse order so they appear correctly. */. Swapping the two gtk_menu_item_new_with_label lines may be the best option?

Change Summary:

fixed the order of the menu items and added a note about it.

Commits:

	Summary	ID
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	fa25e49695df1284796c6c1142dec315bf156e50
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	9dfbab097223a4a7c324e1b22ca48b885d5d585d

Diff:

Revision 3 (+1768 -560)

Show changes

	pidgin/gtkaccount.c
	pidgin/meson.build
	pidgin/pidginproxyoptions.h
	pidgin/pidginproxyoptions.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/proxyoptions.ui
	po/POTFILES.in

Change Summary:

rebased

Commits:

	Summary	ID
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	9dfbab097223a4a7c324e1b22ca48b885d5d585d
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	906548f077557f707d8ff99fa2a43e4fc9ad804e

Diff:

Revision 4 (+1768 -560)

Show changes

	pidgin/gtkaccount.c
	pidgin/meson.build
	pidgin/pidginproxyoptions.h
	pidgin/pidginproxyoptions.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/proxyoptions.ui
	po/POTFILES.in

pidgin/gtkaccount.c (Diff revision 3)
The issue has been resolved. Show all issues
```
This is transfer none, but the end of this function unrefs it?
```
pidgin/pidginproxyoptions.c (Diff revision 3)
The issue has been resolved. Show all issues
```
How does this refresh correctly if options->show_global is set after?
```

Change Summary:

remove unnecessary unref and use a GtkTreeModelFilter for displaying the "Use Global Proxy Settings". Also made PidginProxyOptions always have a valid PurpleProxyInfo.

Commits:

	Summary	ID
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	906548f077557f707d8ff99fa2a43e4fc9ad804e
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	abc60f3d6ad259d73bfffceed238e8ed737f91e9

Diff:

Revision 5 (+1840 -564)

Show changes

	pidgin/gtkaccount.c
	pidgin/meson.build
	pidgin/pidginproxyoptions.h
	pidgin/pidginproxyoptions.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/proxyoptions.ui
	po/POTFILES.in

pidgin/pidginproxyoptions.c (Diff revision 5)
The issue has been resolved. Show all issues
```
Does this need to be done dynamically now that the store is a fixed list?
```
pidgin/pidginproxyoptions.c (Diff revision 5)
The issue has been resolved. Show all issues
```
visible / visibility / the
```

Change Summary:

populate the model in the ui file and fix them typos!

Commits:

	Summary	ID
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	abc60f3d6ad259d73bfffceed238e8ed737f91e9
	Create a PidginProxyOptions widget This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.	f32f8d6e2f1fa44d1f2bcb0cddf1850081d28fcd

Diff:

Revision 6 (+1790 -564)

Show changes

	pidgin/gtkaccount.c
	pidgin/meson.build
	pidgin/pidginproxyoptions.h
	pidgin/pidginproxyoptions.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/proxyoptions.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```

Status:: Completed