Create a PidginProxyOptions widget

Review Request #1377 — Created April 5, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

This replaces the old page in the account editor and uses a PurpleProxyInfo
object to for editing.

Verified it populated saved values on an existing account, as well as saved values on existing account.
Also verified that you can create a new account with proxy options and that they're saved.

Summary ID
Create a PidginProxyOptions widget
This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.
f32f8d6e2f1fa44d1f2bcb0cddf1850081d28fcd
Description From Last Updated

double "the"

lifesfadedlifesfaded

double "the"

lifesfadedlifesfaded

humorous

lifesfadedlifesfaded

Missing space after B)

lifesfadedlifesfaded

This change in behavior is not necessarily a problem, but it looks like these are being prepended in a different …

jrchampjrchamp

This is transfer none, but the end of this function unrefs it?

QuLogicQuLogic

How does this refresh correctly if options->show_global is set after?

QuLogicQuLogic

Does this need to be done dynamically now that the store is a fixed list?

QuLogicQuLogic

visible / visibility / the

QuLogicQuLogic
lifesfaded
  1. 
      
  2. pidgin/pidginproxyoptions.h (Diff revision 1)
     
     

    double "the"

  3. pidgin/pidginproxyoptions.h (Diff revision 1)
     
     

    double "the"

  4. pidgin/pidginproxyoptions.c (Diff revision 1)
     
     

    humorous

  5. pidgin/pidginproxyoptions.c (Diff revision 1)
     
     

    Missing space after B)

  6. 
      
grim
jrchamp
  1. 
      
  2. pidgin/pidginproxyoptions.c (Diff revision 2)
     
     

    This change in behavior is not necessarily a problem, but it looks like these are being prepended in a different order. The original comment said /* Prepend these in reverse order so they appear correctly. */. Swapping the two gtk_menu_item_new_with_label lines may be the best option?

  3. 
      
grim
grim
QuLogic
  1. 
      
  2. pidgin/gtkaccount.c (Diff revision 3)
     
     

    This is transfer none, but the end of this function unrefs it?

  3. pidgin/pidginproxyoptions.c (Diff revision 3)
     
     

    How does this refresh correctly if options->show_global is set after?

  4. 
      
grim
QuLogic
  1. 
      
  2. pidgin/pidginproxyoptions.c (Diff revision 5)
     
     

    Does this need to be done dynamically now that the store is a fixed list?

  3. pidgin/pidginproxyoptions.c (Diff revision 5)
     
     

    visible / visibility / the

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...