Create a PidginProxyOptions widget
Review Request #1377 — Created April 5, 2022 and submitted
This replaces the old page in the account editor and uses a PurpleProxyInfo object to for editing.
Verified it populated saved values on an existing account, as well as saved values on existing account.
Also verified that you can create a new account with proxy options and that they're saved.
Summary | ID |
---|---|
f32f8d6e2f1fa44d1f2bcb0cddf1850081d28fcd |
Description | From | Last Updated |
---|---|---|
double "the" |
lifesfaded | |
double "the" |
lifesfaded | |
humorous |
lifesfaded | |
Missing space after B) |
lifesfaded | |
This change in behavior is not necessarily a problem, but it looks like these are being prepended in a different … |
jrchamp | |
This is transfer none, but the end of this function unrefs it? |
QuLogic | |
How does this refresh correctly if options->show_global is set after? |
QuLogic | |
Does this need to be done dynamically now that the store is a fixed list? |
QuLogic | |
visible / visibility / the |
QuLogic |
Change Summary:
fix some typos found in review
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1764 -560) |
-
-
pidgin/pidginproxyoptions.c (Diff revision 2) This change in behavior is not necessarily a problem, but it looks like these are being prepended in a different order. The original comment said
/* Prepend these in reverse order so they appear correctly. */
. Swapping the two gtk_menu_item_new_with_label lines may be the best option?
Change Summary:
fixed the order of the menu items and added a note about it.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1768 -560) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1768 -560) |
-
-
pidgin/gtkaccount.c (Diff revision 3) This is transfer none, but the end of this function unrefs it?
-
pidgin/pidginproxyoptions.c (Diff revision 3) How does this refresh correctly if
options->show_global
is set after?
Change Summary:
remove unnecessary unref and use a GtkTreeModelFilter for displaying the "Use Global Proxy Settings". Also made PidginProxyOptions always have a valid PurpleProxyInfo.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+1840 -564) |
-
-
pidgin/pidginproxyoptions.c (Diff revision 5) Does this need to be done dynamically now that the store is a fixed list?
-
Change Summary:
populate the model in the ui file and fix them typos!
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+1790 -564) |