Move PurpleProxyInfo from a boxed type to a GObject
Review Request #1368 — Created March 25, 2022 and submitted
As well as: * Fix the namespace of the PurpleProxyType members. * Remove the GNOME proxy detection code. * Remove the Windows proxy detection code.
Created an account and messed around with the proxy settings and verified they were saved and restored.
| Summary | ID |
|---|---|
| 06a31b8325ac379602840befcad5db0c77035a3e |
| Description | From | Last Updated |
|---|---|---|
|
unneeded extra name? |
 lifesfaded
|
|
|
unneeded w on the |
lifesfaded
|
|
|
Should this be g_set_object (and should info be ref'd now)? |
 QuLogic
|
|
|
Returns |
QuLogic
|
|
|
s/:/./ |
QuLogic
|
|
|
Now the callers need to unref what they have, no? |
QuLogic
|
|
|
The G_OBJECT isn't really necessary. |
QuLogic
|
Change Summary:
rebase and fix some typos.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1062 -1396) |
Change Summary:
address issues from review.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1100 -1406) |
Change Summary:
do better at references.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1114 -1408) |
Change Summary:
don't need to typecast for g_object_{un}ref
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+1114 -1408) |
Change Summary:
some last minute fixes i noticed when doing a test run on the canonical repo.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+1114 -1408) |