Move PurpleProxyInfo from a boxed type to a GObject

Review Request #1368 — Created March 25, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

As well as:

 * Fix the namespace of the PurpleProxyType members.
 * Remove the GNOME proxy detection code.
 * Remove the Windows proxy detection code.

Created an account and messed around with the proxy settings and verified they were saved and restored.

Summary ID
Move PurpleProxyInfo from a boxed type to a GObject
As well as: * Fix the namespace of the PurpleProxyType members. * Remove the GNOME proxy detection code. * Remove the Windows proxy detection code.
06a31b8325ac379602840befcad5db0c77035a3e
Description From Last Updated

unneeded extra name?

lifesfadedlifesfaded

unneeded w on the

lifesfadedlifesfaded

Should this be g_set_object (and should info be ref'd now)?

QuLogicQuLogic

Returns

QuLogicQuLogic

s/:/./

QuLogicQuLogic

Now the callers need to unref what they have, no?

QuLogicQuLogic

The G_OBJECT isn't really necessary.

QuLogicQuLogic
lifesfaded
  1. 
      
  2. libpurple/purpleproxyinfo.h (Diff revision 1)
     
     
    Show all issues

    unneeded extra name?

  3. libpurple/purpleproxyinfo.h (Diff revision 1)
     
     
    Show all issues

    unneeded w on the

  4. 
      
grim
QuLogic
  1. 
      
  2. libpurple/account.c (Diff revision 2)
     
     
     
     
     
    Show all issues

    Should this be g_set_object (and should info be ref'd now)?

  3. libpurple/purpleproxyinfo.h (Diff revision 2)
     
     
    Show all issues

    Returns

  4. libpurple/purpleproxyinfo.h (Diff revision 2)
     
     
    Show all issues

    s/:/./

  5. 
      
grim
QuLogic
  1. 
      
  2. libpurple/account.c (Diff revision 3)
     
     
    Show all issues

    Now the callers need to unref what they have, no?

    1. maybe... this gets ugly because of pidgin/purples lack of reference counting in the past... guess i'll search through and see what needs to happen.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. pidgin/gtkaccount.c (Diff revisions 3 - 4)
     
     
    Show all issues

    The G_OBJECT isn't really necessary.

  3. 
      
grim
grim
grim
Review request changed
Status:
Completed