Clean up duplication functions in Facebook prpl
Review Request #1339 — Created March 13, 2022 and submitted — Latest diff uploaded
- Remove weird use of dup functions to allocate new structs
- Replace shallow
*_dup
calls withg_memdup2
org_new0
For a shallow copy, it's far simpler to just callg_memdup2
directly.
In a couple cases where most fields are replaced after, it's simpler to
allocate a new struct entirely and just copy the one or two fields from the
original. - Remove deep parameter from dup functions
All callers all require deep copies now.
Compile only.