Clean up duplication functions in Facebook prpl

Review Request #1339 — Created March 13, 2022 and submitted

QuLogic
pidgin/pidgin
default
1340
pidgin
  • Remove weird use of dup functions to allocate new structs
  • Replace shallow *_dup calls with g_memdup2 or g_new0
    For a shallow copy, it's far simpler to just call g_memdup2 directly.
    In a couple cases where most fields are replaced after, it's simpler to
    allocate a new struct entirely and just copy the one or two fields from the
    original.
  • Remove deep parameter from dup functions
    All callers all require deep copies now.

Compile only.

Summary
Remove weird use of dup functions to allocate new structs
Replace shallow *_dup calls with g_memdup2 or g_new0
Remove deep parameter from dup functions
grim
  1. 
      
  2. Looks good, seeing a lot of complexity being removed here and that's very good, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...