Summary

Convert gtkprivacy.c to GTK4

Review Request #1306 — Created Feb. 18, 2022 and submitted Feb. 23, 2022, 8:36 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

~~1304~~

Reviewers

Groups

pidgin

People

Description

Convert gtkprivacy.c to GTK4

Testing Done

Compiled and verifed that all warnings/errors were fixed in gtkprivacy.c

Commits

Summary	ID
Convert gtkprivacy.c to GTK4	007b1520e4ff2e9e51897c07ca0016a885ccfc99

Issues

Description	From	Last Updated
Don't think there's a need to cast to gpointer?	QuLogic	Feb. 23, 2022, 1:37 a.m.

Ship it!

```
Ship It!
```

pidgin/gtkprivacy.c (Diff revision 1)

Show all issues

Don't think there's a need to cast to gpointer?

grim Feb. 23, 2022, 1:32 a.m.

Without the cast:

$ ninja pidgin/libpidgin3.so.20.0.0.p/gtkprivacy.c.o 
[2/2] Compiling C object pidgin/libpidgin3.so.20.0.0.p/gtkprivacy.c.o
../pidgin/gtkprivacy.c: In function ‘pidgin_privacy_dialog_show’:
../pidgin/gtkprivacy.c:337:43: warning: passing argument 2 of ‘g_object_add_weak_pointer’ from incompatible pointer type [-Wincompatible-pointer-types]
  337 |                                           &privacy_dialog);
      |                                           ^~~~~~~~~~~~~~~
      |                                           |
      |                                           PidginPrivacyDialog ** {aka struct _PidginPrivacyDialog **}
In file included from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:22,
                 from ../libpurple/account.h:30,
                 from libpurple/purple.h:38,
                 from ../pidgin/gtkprivacy.c:24:
/usr/include/glib-2.0/gobject/gobject.h:521:64: note: expected ‘void **’ but argument is of type ‘PidginPrivacyDialog **’ {aka ‘struct _PidginPrivacyDialog **’}
  521 |                                                gpointer       *weak_pointer_location);
      |                                                ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~