Summary

Create new widget and store for choosing status primitives

Review Request #1218 — Created Jan. 7, 2022 and submitted Feb. 10, 2022, 8:18 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Also port the status and substatus editors to the new widget and store.

Testing Done

Messed around with the status and substatus editor a lot, seems to be okay.

Commits

Summary	ID
Create new widget and store for choosing status primitives Also port the status and substatus editors to the new widget and store.	764571e090c60c5b7c916b106f1043f12d8e4595

Issues

Description	From	Last Updated
Why the <pidgin/...> as oppose to "..." like above?	QuLogic	Feb. 10, 2022, 7:59 p.m.
Is there a reason you couldn't keep calling this instead of the two calls below? Is the id from STATUS_COLUMN_STATUS_ID …	QuLogic	Feb. 10, 2022, 8 p.m.
Ah, so related to the previous question, I guess the status ID is not the same as the primitive ID?	QuLogic	Feb. 10, 2022, 8 p.m.
Wrong description.	QuLogic	Feb. 10, 2022, 8 p.m.
Not a combo box.	QuLogic	Feb. 10, 2022, 8 p.m.
This leaks the GList?	QuLogic	Feb. 10, 2022, 8 p.m.
Why clear before set, which should do that?	QuLogic	Feb. 10, 2022, 8 p.m.

pidgin/gtksavedstatuses.c (Diff revision 1)

Show all issues

Why the <pidgin/...> as oppose to "..." like above?

pidgin/gtksavedstatuses.c (Diff revision 1)

Show all issues

Is there a reason you couldn't keep calling this instead of the two calls below? Is the id from STATUS_COLUMN_STATUS_ID different from the combo box IDs?

pidgin/gtksavedstatuses.c (Diff revision 1)

Show all issues

Ah, so related to the previous question, I guess the status ID is not the same as the primitive ID?

grim Feb. 7, 2022, 11:45 p.m.

correct they are different. All statuses have a primitive which has it's own id. The primitives are like available, away, offline, etc, and a status includes that primitive and additional attributes.

For example, XMPP has an available status, with primitive available and an attribute of message. Where IRC's available status, has a primitive of available and no attributes.

pidgin/pidginstatusprimitivestore.h (Diff revision 1)
Show all issues
```
Wrong description.
```
pidgin/pidginstatusprimitivestore.h (Diff revision 1)
Show all issues
```
Not a combo box.
```
pidgin/pidginstatusprimitivestore.c (Diff revision 1)
Show all issues
```
This leaks the GList?
```
pidgin/pidginstatusprimitivestore.c (Diff revision 1)
Show all issues
```
Why clear before set, which should do that?
```

Change Summary:

address found issues

Commits:

	Summary	ID
	Create new widget and store for choosing status primitives Also port the status and substatus editors to the new widget and store.	ff5f417a1f8f81a7af133c1561f8240e954a0aac
	Create new widget and store for choosing status primitives Also port the status and substatus editors to the new widget and store.	764571e090c60c5b7c916b106f1043f12d8e4595

Diff:

Revision 2 (+1132 -272)

Show changes

	pidgin/gtksavedstatuses.c
	pidgin/meson.build
	pidgin/pidginstatusprimitivechooser.h
	pidgin/pidginstatusprimitivechooser.c
	pidgin/pidginstatusprimitivestore.h
	pidgin/pidginstatusprimitivestore.c
	pidgin/glade/pidgin3.xml.in
	pidgin/resources/pidgin.gresource.xml
	2 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Create new widget and store for choosing status primitives

Information

Reviewers

Change Summary:

Commits:

Diff:

Status: Closed (submitted)