added basic tests for path based functions

Review Request #1197 — Created Dec. 23, 2021 and submitted

Information

pidgin/pidgin
default

Reviewers

added basic tests for path based functions

 
Summary ID Author
added basic tests for path based functions
ab8468bfb4ce0a34ddbe696e27771858b0cd3ebc ivanhoe
test_purplepath: replace g_get_home_dir with g_get_user_*_dir functions
77b67141ad1de7160ded98c8e75f241ce99f7788 ivanhoe
Description From Last Updated

There's an issue here with manually building the filenames the way that you are, in that it's using the fallback …

grimgrim
grim
  1. 
      
  2. Show all issues

    There's an issue here with manually building the filenames the way that you are, in that it's using the fallback of g_get_user_*_dir so if we were to ever set the XDG_ environment variables to something else, all of the tests would start failing and we'd have to update them.

    Therefore, instead of using g_get_home_dir we should be using the g_get_user_*_dir functions instead.

  3. 
      
ivanhoe
grim
  1. 
      
  2. Awesome work! Thanks!!

  3. 
      
grim
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed