Summary

Make PidginStatusBox manage its own connecting state.

Review Request #1166 — Created Dec. 11, 2021 and submitted Dec. 31, 2021, 6:38 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Make PidginStatusBox manage its own connecting state.

Testing Done

Connected two accounts, disconnected and reconnected one and made sure the status box properly updated. Also forced an account to fail to connect and verified that the connecting message was shown and then hidden nearly immediately.

Commits

Summary	ID
Make PidginStatusBox manage it's own connecting state.	27d0a79220bad84a077817bab88effa5495b667b

Issues

Description	From	Last Updated
If you disable it while it's connecting, then it'll neither reach the connected state nor be an error?	QuLogic	Dec. 31, 2021, 6:20 a.m.
Do you need to catch signing-off in case the account is disabled before it's fully signed on?	QuLogic	Dec. 31, 2021, 6:21 a.m.

Summary:: Make PidginStatusBox manage it's own connecting state.
Make PidginStatusBox manage its own connecting state.
Description:: ~
Make PidginStatusBox manage it's own connecting state.
~
Make PidginStatusBox manage its own connecting state.

pidgin/gtkstatusbox.c (Diff revision 1)

The issue has been resolved. Show all issues

Do you need to catch signing-off in case the account is disabled before it's fully signed on?

grim Dec. 16, 2021, 9:09 a.m.

I tested the existing code with that, and it just lost track of the accounts state. In other words, it thought it was disabled but it was online. I didn't dig too much into it figuring we'd fix the bug at a later time.

QuLogic Dec. 17, 2021, 3:20 a.m.

Should we leave the signal in here anyway, or a comment so we don't forget about it?

grim Dec. 25, 2021, 8:45 a.m.

I'm still not sure what signing-off does for us? We're tracking connections that are connecting only. Once they're connected they're removed from the list, so there's nothing to do in the signing-off handler. If a connection fails to connect then the connection-error handler gets called and it's removed from the list there.

pidgin/gtkstatusbox.c (Diff revision 1)

The issue has been dropped. Show all issues

If you disable it while it's connecting, then it'll neither reach the connected state nor be an error?

Change Summary:

added a signing-off handler for completeness.

Commits:

	Summary	ID
	Make PidginStatusBox manage it's own connecting state.	692d9d32e188567d028363ba8b805c152d89e33a
	Make PidginStatusBox manage it's own connecting state.	27d0a79220bad84a077817bab88effa5495b667b

Diff:

Revision 2 (+144 -92)

Show changes

	pidgin/gtkconn.c
	pidgin/gtkstatusbox.c

Ship it!

```
Ship It!
```

Status:: Completed