Make PidginStatusBox manage its own connecting state.

 






 

 


  Review Request #1166
  —
  Created Dec. 11, 2021 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Make PidginStatusBox manage its own connecting state.

 








  


 
 

  
Connected two accounts, disconnected and reconnected one and made sure the status box properly updated. Also forced an account to fail to connect and verified that the connecting message was shown and then hidden nearly immediately.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Make PidginStatusBox manage it's own connecting state.


    		
    27d0a79220bad84a077817bab88effa5495b667b

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
If you disable it while it's connecting, then it'll neither reach the connected state nor be an error?

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Do you need to catch signing-off in case the account is disabled before it's fully signed on?

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 



 

  

   




QuLogic




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      pidgin/gtkstatusbox.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Do you need to catch signing-off in case the account is disabled before it's fully signed on?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I tested the existing code with that, and it just lost track of the accounts state. In other words, it thought it was disabled but it was online. I didn't dig too much into it figuring we'd fix the bug at a later time.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Should we leave the signal in here anyway, or a comment so we don't forget about it?
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      I'm still not sure what signing-off does for us? We're tracking connections that are connecting only. Once they're connected they're removed from the list, so there's nothing to do in the signing-off handler. If a connection fails to connect then the connection-error handler gets called and it's removed from the list there.
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      pidgin/gtkstatusbox.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    If you disable it while it's connecting, then it'll neither reach the connected state nor be an error?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...