Summary

port Pidgin to the new PurpleAccountManager api

Review Request #1149 — Created Dec. 7, 2021 and submitted Dec. 14, 2021, 7:15 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

port Pidgin to the new PurpleAccountManager api

Testing Done

Compiled and ran locally, everything seemed to be okay.

Commits

Summary	ID
port Pidgin to the new PurpleAccountManager api	83d46478724e9d862f7baf2097f78dec995b759b

Issues

Description	From	Last Updated
Funny alignment on this.	QuLogic	Dec. 14, 2021, 4:05 a.m.
Swap space/pointer: *	QuLogic	Dec. 14, 2021, 4:03 a.m.
Can replace the second GList here like the other time above.	QuLogic	Dec. 14, 2021, 4:03 a.m.
You can drop the second GList here like the other time.	QuLogic	Dec. 14, 2021, 4:04 a.m.
Also could drop the extra GList.	QuLogic	Dec. 14, 2021, 4:04 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	port Pidgin to the new PurpleAccountManager api	0b3b156bf72e3c71921531c30871ad8cb16415dc
	port Pidgin to the new PurpleAccountManager api	a61b062b87cdc93344c985a473fe89f99cea05a4

Diff:

Revision 2 (+452 -334)

Show changes

	pidgin/gtkaccount.c
	pidgin/gtkblist.c
	pidgin/gtkconn.c
	pidgin/gtkrequest.c
	pidgin/gtksavedstatuses.c
	pidgin/gtkstatusbox.c
	pidgin/gtkutils.c
	pidgin/pidginaccountsmenu.c
	4 more

pidgin/gtkaccount.c (Diff revision 2)
Show all issues
```
Funny alignment on this.
```
pidgin/gtkstatusbox.c (Diff revision 2)
Show all issues
```
Swap space/pointer: *
```

pidgin/gtkstatusbox.c (Diff revision 2)

Show all issues

Can replace the second GList here like the other time above.

pidgin/gtkstatusbox.c (Diff revision 2)

Show all issues

You can drop the second GList here like the other time.

pidgin/plugins/unity.c (Diff revision 2)
Show all issues
```
Also could drop the extra GList.
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	port Pidgin to the new PurpleAccountManager api	a61b062b87cdc93344c985a473fe89f99cea05a4
	port Pidgin to the new PurpleAccountManager api	83d46478724e9d862f7baf2097f78dec995b759b

Diff:

Revision 3 (+474 -344)

Show changes

	pidgin/gtkaccount.c
	pidgin/gtkblist.c
	pidgin/gtkconn.c
	pidgin/gtkrequest.c
	pidgin/gtksavedstatuses.c
	pidgin/gtkstatusbox.c
	pidgin/gtkutils.c
	pidgin/pidginaccountsmenu.c
	4 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

port Pidgin to the new PurpleAccountManager api

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)