Remove teamcity_server var from playbooks

Review Request #1141 — Created Nov. 26, 2021 and submitted

Information

imfreedom/ansible
default

Reviewers

This variable is already defined in the inventory and the way it is right now
prevents us from testing in a local teamcity instance since the value of the
variable available in the playbook will supercede the one we define in a custom
inventory.

Also removing some extra empty newlines at the end of files that are not needed.

Replaced the call to the roles by a simple fail call with a msg that prints the variable value and the printed value was the one it got from the inventory.
Can't really test more than that since I don't have access to the imfreedom teamcity instance but I have no reason to believe that this would break things since the variable is defined for all hosts in inventory/pidgin/hosts.yaml.

Summary ID
Remove teamcity_server var from playbooks
This variable is already defined in the inventory and the way it is right now prevents us from testing in a local teamcity instance since the value of the variable available in the playbook will supercede the one we define in a custom inventory.
5d9cbb8d191ffab6e2bf2ced3a9b6d145e4daa0f
sorvival
grim
  1. Ship It!
  2. Nice find and fix!! Thanks!!

  3. 
      
grim
Review request changed
Status:
Completed