Summary

Remove teamcity_server var from playbooks

Review Request #1141 — Created Nov. 26, 2021 and submitted Nov. 28, 2021, 6:45 a.m.

Information

Owner

sorvival

Repository

imfreedom/ansible

Branch

default

Bugs

Depends On

Reviewers

Groups

infrastructure

People

Description

This variable is already defined in the inventory and the way it is right now
prevents us from testing in a local teamcity instance since the value of the
variable available in the playbook will supercede the one we define in a custom
inventory.

Also removing some extra empty newlines at the end of files that are not needed.

Testing Done

Replaced the call to the roles by a simple fail call with a msg that prints the variable value and the printed value was the one it got from the inventory.
Can't really test more than that since I don't have access to the imfreedom teamcity instance but I have no reason to believe that this would break things since the variable is defined for all hosts in inventory/pidgin/hosts.yaml.

Commits

Summary	ID
Remove teamcity_server var from playbooks This variable is already defined in the inventory and the way it is right now prevents us from testing in a local teamcity instance since the value of the variable available in the playbook will supercede the one we define in a custom inventory.	5d9cbb8d191ffab6e2bf2ced3a9b6d145e4daa0f

Change Summary:: Clarified what testing was done.
Testing Done:: ~
Can't really test that the playbooks are working exactly the same way since I don't have access to the imfreedom teamcity instance but I have no reason to believe that this would break things since the variable is defined for all hosts in inventory/pidgin/hosts.yaml.
~
Replaced the call to the roles by a simple fail call with a msg that prints the variable value and the printed value was the one it got from the inventory.
+ Can't really test more than that since I don't have access to the imfreedom teamcity instance but I have no reason to believe that this would break things since the variable is defined for all hosts in inventory/pidgin/hosts.yaml.

Ship it!

```
Ship It!
```
```
Nice find and fix!! Thanks!!
```

Status:: Completed

~		Can't really test that the playbooks are working exactly the same way since I don't have access to the imfreedom teamcity instance but I have no reason to believe that this would break things since the variable is defined for all hosts in `inventory/pidgin/hosts.yaml`.
	~	Replaced the call to the roles by a simple `fail` call with a msg that prints the variable value and the printed value was the one it got from the inventory.
	+	Can't really test more than that since I don't have access to the imfreedom teamcity instance but I have no reason to believe that this would break things since the variable is defined for all hosts in `inventory/pidgin/hosts.yaml`.