Create the PurpleAccountManager API

Review Request #1137 — Created Nov. 12, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
This replaces most of the purple_accounts_ API, but not quite everything. The
functions that have been replaced have been marked as deprecated and libpurple
has been updated to use the new API.
  • Connected an XMPP account
  • Verified chat and ims worked
  • Verified that the saved statuses window didn't crash
  • Ran the new unit tests.
Summary
Create the PurpleAccountManager API
Description From Last Updated

Can de-align this now?

QuLogicQuLogic

Mark data unused?

QuLogicQuLogic

(void)?

QuLogicQuLogic

Could have a transfer none?

QuLogicQuLogic

It doesn't appear that add takes a ref, so this is transfer full?

QuLogicQuLogic

Re-align

QuLogicQuLogic

removed

QuLogicQuLogic

Double 'the'

QuLogicQuLogic

known

QuLogicQuLogic

its

QuLogicQuLogic

The inner parentheses are redundant.

QuLogicQuLogic

account and verify

QuLogicQuLogic

I think (*count)++ does that?

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/account.c (Diff revision 2)
     
     

    Can de-align this now?

  3. libpurple/accounts.c (Diff revision 2)
     
     

    Mark data unused?

  4. libpurple/buddyicon.c (Diff revision 2)
     
     

    (void)?

  5. libpurple/purpleaccountmanager.h (Diff revision 2)
     
     

    Could have a transfer none?

  6. libpurple/purpleaccountmanager.h (Diff revision 2)
     
     

    It doesn't appear that add takes a ref, so this is transfer full?

  7. libpurple/purpleaccountmanager.c (Diff revision 2)
     
     

    Re-align

  8. libpurple/purpleaccountmanager.c (Diff revision 2)
     
     

    removed

  9. libpurple/purpleaccountmanager.c (Diff revision 2)
     
     

    Double 'the'

  10. libpurple/purpleaccountmanager.c (Diff revision 2)
     
     
  11. libpurple/savedstatuses.c (Diff revision 2)
     
     

    The inner parentheses are redundant.

  12. libpurple/tests/test_account_manager.c (Diff revision 2)
     
     

    account and verify

  13. libpurple/tests/test_account_manager.c (Diff revision 2)
     
     

    I think (*count)++ does that?

  14. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Change Summary:

I had to yolo a fix for purple_account_manager_foreach. It should have had an annotation of (scope call) instead of (scope callback).

Loading...