Summary

Create the PurpleAccountManager API

Review Request #1137 — Created Nov. 12, 2021 and submitted Dec. 3, 2021, 2:01 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This replaces most of the purple_accounts_ API, but not quite everything. The
functions that have been replaced have been marked as deprecated and libpurple
has been updated to use the new API.

Testing Done


Connected an XMPP account
Verified chat and ims worked
Verified that the saved statuses window didn't crash
Ran the new unit tests.

Commits

Summary	ID
Create the PurpleAccountManager API This replaces most of the purple_accounts_ API, but not quite everything. The functions that have been replaced have been marked as deprecated and libpurple has been updated to use the new API.	b3583ba25191f37442f9533a4061dab25a1a4f02

Issues

Description	From	Last Updated
Can de-align this now?	QuLogic	Dec. 3, 2021, 12:24 a.m.
Mark data unused?	QuLogic	Dec. 3, 2021, 12:24 a.m.
(void)?	QuLogic	Dec. 3, 2021, 12:24 a.m.
Could have a transfer none?	QuLogic	Dec. 3, 2021, 12:25 a.m.
It doesn't appear that add takes a ref, so this is transfer full?	QuLogic	Dec. 3, 2021, 12:25 a.m.
Re-align	QuLogic	Dec. 3, 2021, 12:25 a.m.
removed	QuLogic	Dec. 3, 2021, 12:25 a.m.
Double 'the'	QuLogic	Dec. 3, 2021, 12:25 a.m.
known	QuLogic	Dec. 3, 2021, 12:25 a.m.
its	QuLogic	Dec. 3, 2021, 12:25 a.m.
The inner parentheses are redundant.	QuLogic	Dec. 3, 2021, 12:25 a.m.
account and verify	QuLogic	Dec. 3, 2021, 12:26 a.m.
I think (*count)++ does that?	QuLogic	Dec. 3, 2021, 12:26 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Create the PurpleAccountManager API This replaces most of the purple_accounts_ API, but not quite everything. The functions that have been replaced have been marked as deprecated and libpurple has been updated to use the new API.	038efb3c93f5b0aafea172bd59d1caa860d98dd1
	Create the PurpleAccountManager API This replaces most of the purple_accounts_ API, but not quite everything. The functions that have been replaced have been marked as deprecated and libpurple has been updated to use the new API.	4d1e23be398974897322cf0242f0b0b436deb6e2

Diff:

Revision 2 (+1942 -554)

Show changes

	libpurple/account.c
	libpurple/accounts.h
	libpurple/accounts.c
	libpurple/buddyicon.c
	libpurple/buddylist.c
	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleaccountmanager.h
	7 more

libpurple/account.c (Diff revision 2)
Show all issues
```
Can de-align this now?
```
libpurple/accounts.c (Diff revision 2)
Show all issues
```
Mark data unused?
```
libpurple/buddyicon.c (Diff revision 2)
Show all issues
```
(void)?
```
libpurple/purpleaccountmanager.h (Diff revision 2)
Show all issues
```
Could have a transfer none?
```

libpurple/purpleaccountmanager.h (Diff revision 2)

Show all issues

It doesn't appear that add takes a ref, so this is transfer full?

libpurple/purpleaccountmanager.c (Diff revision 2)
Show all issues
```
Re-align
```
libpurple/purpleaccountmanager.c (Diff revision 2)
Show all issues
```
removed
```
libpurple/purpleaccountmanager.c (Diff revision 2)
Show all issues
```
Double 'the'
```
libpurple/purpleaccountmanager.c (Diff revision 2)
Show all issues
```
known
```
libpurple/purpleaccountmanager.c (Diff revision 2)
Show all issues
```
its
```
libpurple/savedstatuses.c (Diff revision 2)
Show all issues
```
The inner parentheses are redundant.
```
libpurple/tests/test_account_manager.c (Diff revision 2)
Show all issues
```
account and verify
```
libpurple/tests/test_account_manager.c (Diff revision 2)
Show all issues
```
I think (*count)++ does that?
```

Change Summary:

address issues found in review.

Commits:

	Summary	ID
	Create the PurpleAccountManager API This replaces most of the purple_accounts_ API, but not quite everything. The functions that have been replaced have been marked as deprecated and libpurple has been updated to use the new API.	4d1e23be398974897322cf0242f0b0b436deb6e2
	Create the PurpleAccountManager API This replaces most of the purple_accounts_ API, but not quite everything. The functions that have been replaced have been marked as deprecated and libpurple has been updated to use the new API.	b3583ba25191f37442f9533a4061dab25a1a4f02

Diff:

Revision 3 (+1946 -558)

Show changes

	libpurple/account.c
	libpurple/accounts.h
	libpurple/accounts.c
	libpurple/buddyicon.c
	libpurple/buddylist.c
	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleaccountmanager.h
	7 more

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

I had to yolo a fix for purple_account_manager_foreach. It should have had an annotation of (scope call) instead of (scope callback).