-
-
-
-
gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1) we don't usually expand this to multiple lines, was this clang-format's doing?
-
gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1) are we doing the
_functions for static? I thought we replaced all of those in gplugin. -
gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1) -might just want to
g_object_geton all of these as well?-nm, that'd require freeing them and stuff..
-
Implement a plugin viewer in GTK4
Review Request #1134 — Created Nov. 12, 2021 and submitted
This may not be a full implementation but there is:
- A simple sorting based on the title (aka plugin name)
- A simple search
- Details toggle when the row is activated
- Enable/disable should work
The design is somewhat inspired by the original GTK3 viewer, Firefox addons, the GNOME extension tool, and maybe a few others I don't remember.
Compile, run to see list of plugins, toggle enable state on a few.
| Summary | ID |
|---|---|
| 6fb49388d4ff58348875d13b041d60c2ef16ac31 | |
| e9a487bb975e0ccf30b58cfff3c7ad3b480da6bf | |
| df6e6a98df55447db1020fff1f1fba83754ee0aa | |
| c4726478af451cadedd97e7d8936545a48cf7296 | |
| 04a959e8e5e60df640086425d13c8297a6c2c649 |
| Description | From | Last Updated |
|---|---|---|
|
Should we be dropping a copyright in these? |
 grim
|
|
|
should be 12? |
grim
|
|
|
we don't usually expand this to multiple lines, was this clang-format's doing? |
grim
|
|
|
are we doing the _ functions for static? I thought we replaced all of those in gplugin. |
grim
|
|
|
-might just want to g_object_get on all of these as well?- nm, that'd require freeing them and stuff.. |
grim
|
|
|
We don't need this cast right? |
grim
|
Change Summary:
Fix review comments
Commits: |
|
|||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+2780 -242) |