Implement a plugin viewer in GTK4

Review Request #1134 — Created Nov. 11, 2021 and submitted

Information

gplugin/gplugin
default

Reviewers

This may not be a full implementation but there is:

  • A simple sorting based on the title (aka plugin name)
  • A simple search
  • Details toggle when the row is activated
  • Enable/disable should work

The design is somewhat inspired by the original GTK3 viewer, Firefox addons, the GNOME extension tool, and maybe a few others I don't remember.

Compile, run to see list of plugins, toggle enable state on a few.

Summary ID
Implement a plugin viewer in GTK4
6fb49388d4ff58348875d13b041d60c2ef16ac31
Add sorting to GTK4 viewer
This is simple sorting based on the title (aka plugin name).
e9a487bb975e0ccf30b58cfff3c7ad3b480da6bf
Add a simple search to GTK4 viewer
df6e6a98df55447db1020fff1f1fba83754ee0aa
Toggle plugin details when the row is activated
c4726478af451cadedd97e7d8936545a48cf7296
Move expander to end of plugin row
This matches the GNOME extension tool, and looks a bit clearer, I think.
04a959e8e5e60df640086425d13c8297a6c2c649

Description From Last Updated

Should we be dropping a copyright in these?

grimgrim

should be 12?

grimgrim

we don't usually expand this to multiple lines, was this clang-format's doing?

grimgrim

are we doing the _ functions for static? I thought we replaced all of those in gplugin.

grimgrim

-might just want to g_object_get on all of these as well?- nm, that'd require freeing them and stuff..

grimgrim

We don't need this cast right?

grimgrim
grim
  1. 
      
  2. gplugin-gtk4/data/plugin-row.ui (Diff revision 1)
     
     
    Show all issues

    Should we be dropping a copyright in these?

    1. We didn't have any in GTK3, but I can grab one.

    2. Good call, skipping is fine.

  3. gplugin-gtk4/data/plugin-row.ui (Diff revision 1)
     
     
    Show all issues

    should be 12?

  4. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     
    Show all issues

    we don't usually expand this to multiple lines, was this clang-format's doing?

    1. Was copied from the GTK3 files.

  5. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     
    Show all issues

    are we doing the _ functions for static? I thought we replaced all of those in gplugin.

    1. Copied that from GTK3, I think?

  6. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     
    Show all issues

    -might just want to g_object_get on all of these as well?-

    nm, that'd require freeing them and stuff..

  7. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     
    Show all issues

    We don't need this cast right?

  8. 
      
QuLogic
grim
  1. Ship It!
  2. Awesome work, thanks!!

  3. 
      
grim
Review request changed
Status:
Completed