Implement a plugin viewer in GTK4

Review Request #1134 — Created Nov. 12, 2021 and updated

QuLogic
gplugin/gplugin
default
pidgin

This may not be a full implementation but there is:

  • A simple sorting based on the title (aka plugin name)
  • A simple search
  • Details toggle when the row is activated
  • Enable/disable should work

The design is somewhat inspired by the original GTK3 viewer, Firefox addons, the GNOME extension tool, and maybe a few others I don't remember.

Compile, run to see list of plugins, toggle enable state on a few.

Summary
Implement a plugin viewer in GTK4
Add sorting to GTK4 viewer
Add a simple search to GTK4 viewer
Toggle plugin details when the row is activated
Move expander to end of plugin row

Description From Last Updated

Should we be dropping a copyright in these?

grimgrim

should be 12?

grimgrim

we don't usually expand this to multiple lines, was this clang-format's doing?

grimgrim

are we doing the _ functions for static? I thought we replaced all of those in gplugin.

grimgrim

-might just want to g_object_get on all of these as well?- nm, that'd require freeing them and stuff..

grimgrim

We don't need this cast right?

grimgrim
grim
  1. 
      
  2. gplugin-gtk4/data/plugin-row.ui (Diff revision 1)
     
     

    Should we be dropping a copyright in these?

  3. gplugin-gtk4/data/plugin-row.ui (Diff revision 1)
     
     

    should be 12?

  4. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     

    we don't usually expand this to multiple lines, was this clang-format's doing?

  5. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     

    are we doing the _ functions for static? I thought we replaced all of those in gplugin.

  6. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     

    -might just want to g_object_get on all of these as well?-

    nm, that'd require freeing them and stuff..

  7. gplugin-gtk4/gplugin-gtk-plugin-row.c (Diff revision 1)
     
     

    We don't need this cast right?

  8. 
      
Loading...