Change Summary:
rebased and added the plugin to potfiles.in
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+900 -24) |
Add a new CredentialProvider for macOS Keychain Access
Review Request #1124 — Created Nov. 5, 2021 and submitted
Add a new CredentialProvider for macOS Keychain Access
- Compiled on Linux and macOS with out issue.
- Added an account with a saved password on macOS, verified the password was stored correctly in keychain access.
- Exited pidgin3, reopened pidgin3, and verified that the account connected without prompting the user.
- Deleted the account and verified that the entry was removed from keychain access.
| Summary | ID |
|---|---|
| 72753295faa710d763c38cdf12fb616548dcd467 |
Testing Done: |
|
|---|
-
-
libpurple/plugins/keychain-access/keychain-access.c (Diff revision 2) I thought we determined this is not necessary for
GTask; it'll clean itself up even without a callback. -
libpurple/plugins/keychain-access/keychain-access.c (Diff revision 2) ... and write doesn't strictly require a callback to continue.
-
libpurple/plugins/keychain-access/keychain-access.c (Diff revision 2) And clear doesn't strictly need a callback.
-
Change Summary:
rebased and addressed issues.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+894 -24) |