Add a new CredentialProvider for macOS Keychain Access

Review Request #1124 — Created Nov. 5, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Add a new CredentialProvider for macOS Keychain Access
  • Compiled on Linux and macOS with out issue.
  • Added an account with a saved password on macOS, verified the password was stored correctly in keychain access.
  • Exited pidgin3, reopened pidgin3, and verified that the account connected without prompting the user.
  • Deleted the account and verified that the entry was removed from keychain access.
Summary
Add a new CredentialProvider for macOS Keychain Access
Description From Last Updated

I thought we determined this is not necessary for GTask; it'll clean itself up even without a callback.

QuLogicQuLogic

... and write doesn't strictly require a callback to continue.

QuLogicQuLogic

And clear doesn't strictly need a callback.

QuLogicQuLogic

Extra space here.

QuLogicQuLogic
grim
QuLogic
QuLogic
  1. 
      
  2. I thought we determined this is not necessary for GTask; it'll clean itself up even without a callback.

    1. Oh that's right.. I couldn't remember at the time so I just threw it in there :-/

  3. ... and write doesn't strictly require a callback to continue.

  4. And clear doesn't strictly need a callback.

  5. Extra space here.

  6. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...