Summary

Add a new CredentialProvider for macOS Keychain Access

Review Request #1124 — Created Nov. 5, 2021 and submitted Nov. 15, 2021, 10:04 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add a new CredentialProvider for macOS Keychain Access

Testing Done


Compiled on Linux and macOS with out issue.
Added an account with a saved password on macOS, verified the password was stored correctly in keychain access.
Exited pidgin3, reopened pidgin3, and verified that the account connected without prompting the user.
Deleted the account and verified that the entry was removed from keychain access.

Commits

Summary	ID
Add a new CredentialProvider for macOS Keychain Access	72753295faa710d763c38cdf12fb616548dcd467

Issues

Description	From	Last Updated
I thought we determined this is not necessary for GTask; it'll clean itself up even without a callback.	QuLogic	Nov. 15, 2021, 9:59 a.m.
... and write doesn't strictly require a callback to continue.	QuLogic	Nov. 15, 2021, 9:59 a.m.
And clear doesn't strictly need a callback.	QuLogic	Nov. 15, 2021, 9:59 a.m.
Extra space here.	QuLogic	Nov. 15, 2021, 9:59 a.m.

Change Summary:

rebased and added the plugin to potfiles.in

Commits:

	Summary	ID
	Add a new CredentialProvider for macOS Keychain Access	a2df31f72117b4b1c601844dc0580e78e1ef78dc
	Add a new CredentialProvider for macOS Keychain Access	4d91f2264bb8ca5c874f7d45761ae24ae78682ac

Diff:

Revision 2 (+900 -24)

Show changes

	meson.build
	libpurple/plugins/meson.build
	libpurple/plugins/keychain-access/keychain-access.c
	libpurple/plugins/keychain-access/meson.build
	po/POTFILES.in

Testing Done:: Compiled on Linux and macOS with out issue.
~
Added an account with a saved password on macOS, verfied the password was stored correctly in keychain access.
~
Exited pidgin3, reopened pidgin3, and verfied that the account connected without prompting the user.
~
Added an account with a saved password on macOS, verified the password was stored correctly in keychain access.
~
Exited pidgin3, reopened pidgin3, and verified that the account connected without prompting the user.

Deleted the account and verified that the entry was removed from keychain access.

libpurple/plugins/keychain-access/keychain-access.c (Diff revision 2)

The issue has been resolved. Show all issues

I thought we determined this is not necessary for GTask; it'll clean itself up even without a callback.

grim Nov. 15, 2021, 8:27 a.m.

Oh that's right.. I couldn't remember at the time so I just threw it in there :-/

libpurple/plugins/keychain-access/keychain-access.c (Diff revision 2)
The issue has been resolved. Show all issues
```
... and write doesn't strictly require a callback to continue.
```
libpurple/plugins/keychain-access/keychain-access.c (Diff revision 2)
The issue has been resolved. Show all issues
```
And clear doesn't strictly need a callback.
```
libpurple/plugins/keychain-access/meson.build (Diff revision 2)
The issue has been resolved. Show all issues
```
Extra space here.
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add a new CredentialProvider for macOS Keychain Access	4d91f2264bb8ca5c874f7d45761ae24ae78682ac
	Add a new CredentialProvider for macOS Keychain Access	72753295faa710d763c38cdf12fb616548dcd467

Diff:

Revision 3 (+894 -24)

Show changes

	meson.build
	libpurple/plugins/meson.build
	libpurple/plugins/keychain-access/keychain-access.c
	libpurple/plugins/keychain-access/meson.build
	po/POTFILES.in

Ship it!

```
Ship It!
```

Status:: Completed

		Compiled on Linux and macOS with out issue.
~		Added an account with a saved password on macOS, verfied the password was stored correctly in keychain access.
~		Exited pidgin3, reopened pidgin3, and verfied that the account connected without prompting the user.
	~	Added an account with a saved password on macOS, verified the password was stored correctly in keychain access.
	~	Exited pidgin3, reopened pidgin3, and verified that the account connected without prompting the user.
		Deleted the account and verified that the entry was removed from keychain access.