Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR

Review Request #1113 — Created Oct. 29, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Also fixed up a LOT of style stuff.

Connected an xmpp account and verified it didn't crash.

Summary
Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR
Description From Last Updated

Should this doc go on PURPLE_CONNECTION_ERROR?

QuLogicQuLogic

Is this macro not recommended?

QuLogicQuLogic

I know you weren't doing cleanup, but this is the only if where you didn't add braces.

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/connection.h (Diff revision 1)
     
     

    Should this doc go on PURPLE_CONNECTION_ERROR?

  3. libpurple/connection.c (Diff revision 1)
     
     

    Is this macro not recommended?

    1. Honestly never seen it before, and it depends on having a macro in the header too, so why not just use the static string which is just a single line.

  4. libpurple/connection.c (Diff revision 2)
     
     
     
     
     

    I know you weren't doing cleanup, but this is the only if where you didn't add braces.

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...