Summary

Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR

Review Request #1113 — Created Oct. 28, 2021 and submitted Oct. 29, 2021, 4:35 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Also fixed up a LOT of style stuff.

Testing Done

Connected an xmpp account and verified it didn't crash.

Commits

Summary	ID
Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR Also fixed up a LOT of style stuff.	cde5798a4e27be58c723eea95d70e432ad0417fc

Issues

Description	From	Last Updated
Should this doc go on PURPLE_CONNECTION_ERROR?	QuLogic	Oct. 29, 2021, 12:38 a.m.
Is this macro not recommended?	QuLogic	Oct. 29, 2021, 12:38 a.m.
I know you weren't doing cleanup, but this is the only if where you didn't add braces.	QuLogic	Oct. 29, 2021, 12:38 a.m.

Change Summary:

make sure the PURPLE_CONNECTION_ERROR uses the correct amount of ()'s

Commits:

	Summary	ID
	Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR Also fixed up a LOT of style stuff.	68d4d842e70512bdeeaff8fb3fb7f8a54cd3be56
	Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR Also fixed up a LOT of style stuff.	9e65a883f33e3f9cf02fbf0c8116312dbc733d8b

Diff:

Revision 2 (+448 -640)

Show changes

	libpurple/connection.h
	libpurple/connection.c

libpurple/connection.h (Diff revision 1)

Show all issues

Should this doc go on PURPLE_CONNECTION_ERROR?

libpurple/connection.c (Diff revision 1)

Show all issues

Is this macro not recommended?

grim Oct. 29, 2021, 12:37 a.m.

Honestly never seen it before, and it depends on having a macro in the header too, so why not just use the static string which is just a single line.

libpurple/connection.c (Diff revision 2)

Show all issues

I know you weren't doing cleanup, but this is the only if where you didn't add braces.

Commits:

	Summary	ID
	Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR Also fixed up a LOT of style stuff.	9e65a883f33e3f9cf02fbf0c8116312dbc733d8b
	Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR Also fixed up a LOT of style stuff.	cde5798a4e27be58c723eea95d70e432ad0417fc

Diff:

Revision 3 (+456 -636)

Show changes

	libpurple/connection.h
	libpurple/connection.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Remove private data from PurpleConnection and fix up PURPLE_CONNECTION_ERROR

Information

Reviewers

Change Summary:

Commits:

Diff:

Commits:

Diff:

Status: Closed (submitted)