Fix some media relay info issues

Review Request #1106 — Created Oct. 26, 2021 and submitted

Information

pidgin/pidgin
default

Reviewers

  • Use GPtrArray for Jingle relay info
    This is already used for relay info in the FarStream backend, so is probably the right change to make there.
  • Fix possible leak when creating FarStream stream
    The relay info is created before some early returns, but without being freed there. It can be created within a condition where it's really needed instead. Then telling the GValue to take it means we don't need to free it ourselves.

Compile only.

Summary ID
Use GPtrArray for Jingle relay info
This is already used for relay info in the FarStream backend, so is probably the right change to make there.
1f3affbbd7c70e0b32dfa4c425f9382eee11eaa7
Fix possible leak when creating FarStream stream
The relay info is created before some early returns, but without being freed there. It can be created within a condition where it's really needed instead. Then telling the GValue to take it means we don't need to free it ourselves.
b047a9953dd3e8effe91a8b75d56b2ffbebfc9d9
grim
  1. Ship It!
  2. Nice work! Thanks!!

  3. 
      
grim
Review request changed
Status:
Completed