Summary

Rename the strangely named load-on-query property to the much more obvious auto-load

Review Request #1094 — Created Oct. 23, 2021 and submitted Sept. 27, 2022, 5:10 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Rename the strangely named load-on-query property to the much more obvious auto-load

Testing Done

Ran the unit tests

Commits

Summary	ID
Rename the strangely named load-on-query property to the much more obvious auto-load	5c04fbcf4f58e79912e088b32ea811a3300ac5a6

Issues

Description	From	Last Updated
Seems fine, but renaming a function definitely needs a soversion bump, no?	QuLogic	May 30, 2022, 7:02 a.m.
Usually we indent the wrapped lines to the :?	QuLogic	Sept. 27, 2022, 4:28 a.m.
Add note somewhere to use auto-load instead.	QuLogic	Sept. 27, 2022, 4:28 a.m.
Add note to use _get_auto_load instead.	QuLogic	Sept. 27, 2022, 4:29 a.m.
Should keep one test that setting load-on-query still works.	QuLogic	Sept. 27, 2022, 4:48 a.m.
Don't think this passes clang-format.	QuLogic	Sept. 27, 2022, 5:01 a.m.

Show all issues

Seems fine, but renaming a function definitely needs a soversion bump, no?

grim Oct. 24, 2021, 7:03 a.m.

We're still no api/stability guaranty.. So no? I mean we didn't bump the so version when we changed the signature of gplugin_manager-* either. Worst case I can just leave the old functions for now, but I didn't really want to leave a bunch of deprecated stuff in a pre stable api.

Change Summary:

re-add the loq api

Commits:

	Summary	ID
	Rename the strangely named load-on-query property to the much more obvious auto-load	3480c23bdb93732688071a2a6257e61ea7af7f4f
	Rename the strangely named load-on-query property to the much more obvious auto-load	41068e2d6e6cbdc68c460ff2833edf5789a1e6cb

Diff:

Revision 2 (+252 -164)

Show changes

	gplugin/gplugin-manager.c
	gplugin/gplugin-plugin-info.h
	gplugin/gplugin-plugin-info.c
	gplugin/tests/meson.build
	gplugin/tests/test-load-on-query.c
	gplugin/tests/test-plugin-info.c
	gplugin/tests/load-on-query-fail/load-on-query-fail.c
	gplugin/tests/load-on-query-fail/meson.build
	5 more

gplugin/gplugin-manager.c (Diff revision 2)
Show all issues
```
Usually we indent the wrapped lines to the :?
```
gplugin/gplugin-plugin-info.c (Diff revision 2)
Show all issues
```
Add note somewhere to use auto-load instead.
```
gplugin/gplugin-plugin-info.c (Diff revision 2)
Show all issues
```
Add note to use _get_auto_load instead.
```

Change Summary:

super rebased and addressed issues.

Commits:

	Summary	ID
	Rename the strangely named load-on-query property to the much more obvious auto-load	41068e2d6e6cbdc68c460ff2833edf5789a1e6cb
	Rename the strangely named load-on-query property to the much more obvious auto-load	48cdffe4b11ed2094f02c986bcc4f8f4813d927d

Diff:

Revision 3 (+252 -158)

Show changes

	gplugin/gplugin-file-source.c
	gplugin/gplugin-plugin-info.h
	gplugin/gplugin-plugin-info.c
	gplugin/tests/meson.build
	gplugin/tests/test-load-on-query.c
	gplugin/tests/test-plugin-info.c
	gplugin/tests/load-on-query-fail/load-on-query-fail.c
	gplugin/tests/load-on-query-fail/meson.build
	4 more

gplugin/tests/auto-load-pass/auto-load-pass.c (Diff revision 3)
Show all issues
```
Should keep one test that setting load-on-query still works.
```

Change Summary:

add a unit test to make sure the load-on-query property is still honored.

Commits:

	Summary	ID
	Rename the strangely named load-on-query property to the much more obvious auto-load	48cdffe4b11ed2094f02c986bcc4f8f4813d927d
	Rename the strangely named load-on-query property to the much more obvious auto-load	ed8f4accf0a7f4ee359b497d19b826bde31dc37a

Diff:

Revision 4 (+290 -156)

Show changes

	gplugin/gplugin-file-source.c
	gplugin/gplugin-plugin-info.h
	gplugin/gplugin-plugin-info.c
	gplugin/tests/meson.build
	gplugin/tests/test-load-on-query.c
	gplugin/tests/test-plugin-info.c
	gplugin/tests/load-on-query-fail/load-on-query-fail.c
	gplugin/tests/load-on-query-fail/meson.build
	4 more

gplugin/tests/test-auto-load.c (Diff revision 4)
Show all issues
```
Don't think this passes clang-format.
```

Change Summary:

ran clang-format

Commits:

	Summary	ID
	Rename the strangely named load-on-query property to the much more obvious auto-load	ed8f4accf0a7f4ee359b497d19b826bde31dc37a
	Rename the strangely named load-on-query property to the much more obvious auto-load	5c04fbcf4f58e79912e088b32ea811a3300ac5a6

Diff:

Revision 5 (+298 -154)

Show changes

	gplugin/gplugin-file-source.c
	gplugin/gplugin-plugin-info.h
	gplugin/gplugin-plugin-info.c
	gplugin/tests/meson.build
	gplugin/tests/test-load-on-query.c
	gplugin/tests/test-plugin-info.c
	gplugin/tests/load-on-query-fail/load-on-query-fail.c
	gplugin/tests/load-on-query-fail/meson.build
	4 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Rename the strangely named load-on-query property to the much more obvious auto-load

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

gplugin/gplugin-manager.c (Diff revision 2)