Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation

Review Request #1087 — Created Oct. 21, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation

ran meson --wipe && ninja and verified a BUNCH of warnings magically disappeared into oblivion.

Summary
Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation
Description From Last Updated

This apparently breaks docs.

QuLogicQuLogic

So Facebook docs also complain; do they need this include on the dummy gir?

QuLogicQuLogic

If this is not dynamic, maybe we should inline it like the others?

QuLogicQuLogic

I wonder if this should be passed libpurple_gir instead of Purple-3.0? But maybe we shouldn't, if libpurple is eventually moving ...

QuLogicQuLogic

Sorry, also libpurple_gir on this one?

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/meson.build (Diff revision 1)
     
     

    If this is not dynamic, maybe we should inline it like the others?

  3. pidgin/meson.build (Diff revision 1)
     
     

    I wonder if this should be passed libpurple_gir instead of Purple-3.0?

    But maybe we shouldn't, if libpurple is eventually moving to a subproject.

  4. 
      
grim
QuLogic
  1. 
      
  2. finch/meson.build (Diff revision 2)
     
     

    Sorry, also libpurple_gir on this one?

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
QuLogic
  1. 
      
  2. This apparently breaks docs.

  3. So Facebook docs also complain; do they need this include on the dummy gir?

    1. It needs libpurple_gir[0] and Json-1.0.

  4. 
      
grim
grim
grim
QuLogic
  1. Ship It!
  2. It's kind of a hack, but it seems to work.

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...