Summary

Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation

Review Request #1087 — Created Oct. 21, 2021 and submitted Oct. 26, 2021, 3:06 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation

Testing Done

ran meson --wipe && ninja and verified a BUNCH of warnings magically disappeared into oblivion.

Commits

Summary	ID
Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	7750ac2ead8182aed2abef914c37d73fe7d2e7db

Issues

Description	From	Last Updated
This apparently breaks docs.	QuLogic	Oct. 23, 2021, 4:42 a.m.
So Facebook docs also complain; do they need this include on the dummy gir?	QuLogic	Oct. 26, 2021, 2:56 a.m.
If this is not dynamic, maybe we should inline it like the others?	QuLogic	Oct. 22, 2021, 4:28 a.m.
I wonder if this should be passed libpurple_gir instead of Purple-3.0? But maybe we shouldn't, if libpurple is eventually moving …	QuLogic	Oct. 22, 2021, 4:28 a.m.
Sorry, also libpurple_gir on this one?	QuLogic	Oct. 22, 2021, 4:31 a.m.

libpurple/meson.build (Diff revision 1)

Show all issues

If this is not dynamic, maybe we should inline it like the others?

pidgin/meson.build (Diff revision 1)

Show all issues

I wonder if this should be passed libpurple_gir instead of Purple-3.0?

But maybe we shouldn't, if libpurple is eventually moving to a subproject.

Change Summary:

address concerns.

Commits:

	Summary	ID
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	bece0ac4918ea970e32c91908ae2886e4c6fc6f9
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	a00dbb110900a38d9238cc7f92dd412ff2818e86

Diff:

Revision 2 (+8 -10)

Show changes

	finch/meson.build
	libpurple/meson.build
	pidgin/meson.build

finch/meson.build (Diff revision 2)
Show all issues
```
Sorry, also libpurple_gir on this one?
```

Commits:

	Summary	ID
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	a00dbb110900a38d9238cc7f92dd412ff2818e86
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	a3a1ee469bf95c23f6403a0b850328764c4d8f34

Diff:

Revision 3 (+8 -10)

Show changes

	finch/meson.build
	libpurple/meson.build
	pidgin/meson.build

Ship it!

```
Ship It!
```

Show all issues
```
This apparently breaks docs.
```

Show all issues

So Facebook docs also complain; do they need this include on the dummy gir?

QuLogic Oct. 23, 2021, 4:43 a.m.
```
It needs libpurple_gir[0] and Json-1.0.
```

Change Summary:

use a bunch of hacks to just make this work for now. Hopefully when gi-docgen gets added to the gnome meson module this can all get removed...

Commits:

	Summary	ID
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	a3a1ee469bf95c23f6403a0b850328764c4d8f34
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	096edf5312e7878be270796187f5e654e5f23ca3

Diff:

Revision 4 (+34 -12)

Show changes

	doc/reference/finch/meson.build
	doc/reference/pidgin/meson.build
	doc/reference/protocols/facebook/meson.build
	finch/meson.build
	libpurple/meson.build
	pidgin/meson.build

Change Summary:

also bump meson to 0.58.0 as we're using global_build_root in the hacks.

Commits:

	Summary	ID
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	096edf5312e7878be270796187f5e654e5f23ca3
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	75392d927b1b90e3c7239cbd5c23ad2084320f8a

Diff:

Revision 5 (+36 -14)

Show changes

	meson.build
	doc/reference/finch/meson.build
	doc/reference/pidgin/meson.build
	doc/reference/protocols/facebook/meson.build
	finch/meson.build
	libpurple/meson.build
	pidgin/meson.build

Change Summary:

update the facebook stuff

Commits:

	Summary	ID
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	75392d927b1b90e3c7239cbd5c23ad2084320f8a
	Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation	7750ac2ead8182aed2abef914c37d73fe7d2e7db

Diff:

Revision 6 (+38 -16)

Show changes

	meson.build
	doc/reference/finch/meson.build
	doc/reference/pidgin/meson.build
	doc/reference/protocols/facebook/meson.build
	finch/meson.build
	libpurple/meson.build
	libpurple/protocols/facebook/meson.build
	pidgin/meson.build

Ship it!

```
Ship It!
```

It's kind of a hack, but it seems to work.

Review Board 6.0.2

Fix includes for the introspection targets that I thought weren't needed during the gi-docgen conversation

Information

Reviewers

Change Summary:

Commits:

Diff:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)