Route GLib logging directly to the Pidgin debug window

Review Request #1058 — Created Oct. 18, 2021 and submitted

Information

pidgin/pidgin
default

Reviewers

Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.

Open Debug Window and see stuff from GLib-* still appearing.

Summary ID
Route GLib logging directly to the Pidgin debug window
8422e5d18e84f124ba6b28a47ac2eb02583a20fb
Close the Debug Window on shutdown
Otherwise, it tries to read prefs after that subsystem is shut down.
e05762e9da8b10de6a7a81119aae5bc4d29ce3be
Description From Last Updated

On shutdown, this causes: purple_prefs_get_bool: Unknown pref /pidgin/debug/enabled but not during runtime. I guess there's some shutdown order problem.

QuLogicQuLogic

might want to add the node about prefs already being shutdown here.

grimgrim
QuLogic
QuLogic
  1. 
      
  2. On shutdown, this causes:
    purple_prefs_get_bool: Unknown pref /pidgin/debug/enabled

    but not during runtime. I guess there's some shutdown order problem.

  3. 
      
QuLogic
grim
  1. 
      
  2. pidgin/libpidgin.c (Diff revision 3)
     
     

    might want to add the node about prefs already being shutdown here.

    1. It's not shut down here, but after core UI is shut down (which is here).

    2. right, i was saying to explain why the window is being hidden here.

  3. 
      
QuLogic
grim
  1. Ship It!
  2. Nice work, very excited for an end for the purple_debug_ api in site. Thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...