Summary

Route GLib logging directly to the Pidgin debug window

Review Request #1058 — Created Oct. 18, 2021 and submitted Oct. 18, 2021, 7:44 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Instead of flowing through purple debug, this merges some bits of the existing GLib log handler, and the purple debug printer.

Testing Done

Open Debug Window and see stuff from GLib-* still appearing.

Commits

Summary	ID
Route GLib logging directly to the Pidgin debug window	8422e5d18e84f124ba6b28a47ac2eb02583a20fb
Close the Debug Window on shutdown Otherwise, it tries to read prefs after that subsystem is shut down.	e05762e9da8b10de6a7a81119aae5bc4d29ce3be

Issues

Description	From	Last Updated
On shutdown, this causes: purple_prefs_get_bool: Unknown pref /pidgin/debug/enabled but not during runtime. I guess there's some shutdown order problem.	QuLogic	Oct. 18, 2021, 1 a.m.
might want to add the node about prefs already being shutdown here.	grim	Oct. 18, 2021, 7:43 a.m.

Change Summary:

Small formatting tweaks.

Commits:

	Summary	ID
	Route GLib logging directly to the Pidgin debug window	51b307e31e9e8541e646ee3d9871627b3c128c2c
	Route GLib logging directly to the Pidgin debug window	c2bd6d4f4551684ef6322d4f1ca704ffaa8ab3f7

Diff:

Revision 2 (+220 -62)

Show changes

pidgin/pidgindebug.c

The issue has been resolved. Show all issues

On shutdown, this causes:
purple_prefs_get_bool: Unknown pref /pidgin/debug/enabled

but not during runtime. I guess there's some shutdown order problem.

Change Summary:

Close the Debug Window on shutdown.
Otherwise, it tries to read prefs after that subsystem is shut down.

Commits:

	Summary	ID
	Route GLib logging directly to the Pidgin debug window	c2bd6d4f4551684ef6322d4f1ca704ffaa8ab3f7
	Route GLib logging directly to the Pidgin debug window	c2bd6d4f4551684ef6322d4f1ca704ffaa8ab3f7
	Close the Debug Window on shutdown Otherwise, it tries to read prefs after that subsystem is shut down.	fb359ee06e1a5715c09c778b2c1ec9e8412e58f6

Diff:

Revision 3 (+222 -62)

Show changes

	pidgin/libpidgin.c
	pidgin/pidgindebug.c

pidgin/libpidgin.c (Diff revision 3)

The issue has been resolved. Show all issues

might want to add the node about prefs already being shutdown here.

QuLogic Oct. 18, 2021, 6:26 a.m.

It's not shut down here, but after core UI is shut down (which is here).

grim Oct. 18, 2021, 6:59 a.m.

right, i was saying to explain why the window is being hidden here.

Change Summary:

Add comment about hiding the debug window.

Commits:

	Summary	ID
	Route GLib logging directly to the Pidgin debug window	c2bd6d4f4551684ef6322d4f1ca704ffaa8ab3f7
	Close the Debug Window on shutdown Otherwise, it tries to read prefs after that subsystem is shut down.	fb359ee06e1a5715c09c778b2c1ec9e8412e58f6
	Route GLib logging directly to the Pidgin debug window	8422e5d18e84f124ba6b28a47ac2eb02583a20fb
	Close the Debug Window on shutdown Otherwise, it tries to read prefs after that subsystem is shut down.	e05762e9da8b10de6a7a81119aae5bc4d29ce3be

Diff:

Revision 4 (+228 -62)

Show changes

	pidgin/libpidgin.c
	pidgin/pidgindebug.c

Ship it!

```
Ship It!
```

Nice work, very excited for an end for the purple_debug_ api in site. Thanks!!

Status:: Completed